[office-addin-dev-settings] Update version of the commander dependency

[TheSamsterZA]

Resolves #337.

[ghost]

All CLA requirements met.

[TheSamsterZA]

I understand that commander is used across multiple office-addin packages, but was not sure if it was a good idea to update the dependency across all of them in one PR. I decided to limit my change to the package I was having trouble with.

[TCourtneyOwen]

/AzurePipelines run

[azure-pipelines]

Pull request contains merge conflicts.

[TCourtneyOwen]

@TheSamsterZA Please resolve merge conflicts and submit a new iteration.

Thanks,

Courtney

[akrantz]

Thanks for bringing this to our attention. I think we should update this for all of the packages within office-addin-scripts.

[akrantz]

Let's update this for all of the packages in office-addin-scripts.

[akrantz]

Also, is there a related update needed for @types/commander?

[akrantz]

It appears that @types/command is not actually needed. It would be nice to remove that.

[akrantz]

One other thing, with the major version update to commander, we'll need to ensure that there are no breaking changes which cause a problem. We don't have tests for the CLI itself. The release notes for the major version updates describe breaking changes: https://github.com/tj/commander.js/tags @TCourtneyOwen We can talk offline how best to validate this.

[TheSamsterZA]

@akrantz:

Let's update this for all of the packages in office-addin-scripts.

I've submitted a new pull request #339 which does this. Please review.

[TheSamsterZA]

Closing since #339 supersedes this PR.