-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office-Addin-Scripts: update commander dependency #339
Office-Addin-Scripts: update commander dependency #339
Conversation
Update fork
Updates the following packages that have a direct dependency on commander: custom-functions-metadata office-addin-cli office-addin-debugging office-addin-dev-certs office-addin-dev-settings office-addin-lint office-addin-manifest office-addin-node-debugger office-addin-sso office-addin-test-server office-addin-usage-data
Removed from the following packages: custom-functions-metadata office-addin-lint
/AzurePipelines run |
No pipelines are associated with this pull request. |
@TCourtneyOwen hello, do I need to do something special to get the Azure Pipelines build to run? |
@TheSamsterZA No, @TCourtneyOwen will look into it. |
@TheSamsterZA I wanted to also say thanks for making the updates. In the future, you can use the original pull request and just push additional commits to that branch. It's not neccessary to make a new pull request. |
@TheSamsterZA I kicked off the run yesterday but it failed because of a problem with the VMs in the our CI Loop. I am fixing that this morning and will rerun the job. I am sure it will pass then and I will merge your change. Thanks, Courtney |
I did some testing and I didn't seen any problems introduced from the latest version of commander. |
/AzurePipelines run |
No pipelines are associated with this pull request. |
CI job passed. I think we can go ahead and merge this now |
I have published new versions of the packages updated in this PR. -Courtney |
Thanks all! 😄 |
Resolves #337.
As requested by @akrantz in #338 (review).
Updates the following packages that have a direct dependency on commander:
custom-functions-metadata
office-addin-cli
office-addin-debugging
office-addin-dev-certs
office-addin-dev-settings
office-addin-lint
office-addin-manifest
office-addin-node-debugger
office-addin-sso
office-addin-test-server
office-addin-usage-data