Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office-Addin-Scripts: update commander dependency #339

Merged

Conversation

TheSamsterZA
Copy link
Contributor

Resolves #337.

As requested by @akrantz in #338 (review).

Updates the following packages that have a direct dependency on commander:
custom-functions-metadata
office-addin-cli
office-addin-debugging
office-addin-dev-certs
office-addin-dev-settings
office-addin-lint
office-addin-manifest
office-addin-node-debugger
office-addin-sso
office-addin-test-server
office-addin-usage-data

TheSamsterZA and others added 2 commits November 14, 2020 22:28
Updates the following packages that have a direct dependency on commander:
custom-functions-metadata
office-addin-cli
office-addin-debugging
office-addin-dev-certs
office-addin-dev-settings
office-addin-lint
office-addin-manifest
office-addin-node-debugger
office-addin-sso
office-addin-test-server
office-addin-usage-data
@TheSamsterZA TheSamsterZA requested a review from a team as a code owner November 14, 2020 16:18
@TheSamsterZA TheSamsterZA changed the title Office add in scripts/update commander Office-Addin-Scripts: update commander dependency Nov 14, 2020
Removed from the following packages:
custom-functions-metadata
office-addin-lint
@TCourtneyOwen
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@TheSamsterZA
Copy link
Contributor Author

@TCourtneyOwen hello, do I need to do something special to get the Azure Pipelines build to run?

@akrantz
Copy link
Contributor

akrantz commented Nov 16, 2020

@TheSamsterZA No, @TCourtneyOwen will look into it.

@akrantz
Copy link
Contributor

akrantz commented Nov 16, 2020

@TheSamsterZA I wanted to also say thanks for making the updates. In the future, you can use the original pull request and just push additional commits to that branch. It's not neccessary to make a new pull request.

@TCourtneyOwen
Copy link
Contributor

@TheSamsterZA I kicked off the run yesterday but it failed because of a problem with the VMs in the our CI Loop. I am fixing that this morning and will rerun the job. I am sure it will pass then and I will merge your change.

Thanks,

Courtney

@akrantz
Copy link
Contributor

akrantz commented Nov 16, 2020

I did some testing and I didn't seen any problems introduced from the latest version of commander.

@TCourtneyOwen
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@TCourtneyOwen
Copy link
Contributor

CI job passed. I think we can go ahead and merge this now

@akrantz akrantz merged commit 2860420 into OfficeDev:master Nov 16, 2020
@TCourtneyOwen
Copy link
Contributor

I have published new versions of the packages updated in this PR.

-Courtney

@TheSamsterZA
Copy link
Contributor Author

Thanks all! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[office-addin-dev-settings] Update commander dependency
3 participants