Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let --update also check :override-deps #10

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Nov 15, 2018

We were checking :deps and :extra-deps but not :override-deps. Since the regular
check also considers this key, --update should to.

Note that you can still opt out of updating certain versions with
^:depot/ignore, either on the version map or on the deps map.

Closes #9

We were checking :deps and :extra-deps but not :override-deps. Since the regular
check also considers this key, --update should to.

Note that you can still opt out of updating certain versions with
^:depot/ignore, either on the version map or on the deps map.
Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was quick, looks great too. I like the refactor into update-key. The zipper rewriting is really neat, I need to explore it some more. Great choice of tools!

I think I'll write a test suite on a rainy day that tests all of these data manipulating functions in isolation so we can lock some of this functionality down. I'm sorry I didn't have a test suite in the first place, I spent most of my time stressing about how to look things up in maven while trying to get this working 😬

@Olical Olical merged commit 3af4cea into Olical:master Nov 15, 2018
@plexus
Copy link
Contributor Author

plexus commented Nov 15, 2018

There's always room for improvement :) thanks for a great tool! It's the kind of thing I would have written myself if you hadn't already, so happy to lend a hand.

@plexus plexus deleted the update-override-deps branch November 16, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants