Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "RELEASE" and "LATEST", bring back Clojure 1.8 compatibility #9

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Nov 14, 2018

In Maven 2 the special version identifiers "RELEASE" and "LATEST" could be used.
These should not be replaced with concrete version numbers.

Prior to Clojure 1.9 there were no namespaced maps, make sure the code still
compiles on those versions.

Closes #7

In Maven 2 the special version identifiers "RELEASE" and "LATEST" could be used.
These should not be replaced with concrete version numbers.

Prior to Clojure 1.9 there were no namespaced maps, make sure the code still
compiles on those versions.
Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat, will just wait to see if Sean is happy.

`(binding [*print-namespace-maps* ~bool]
~@body)
;; pre Clojure 1.9
`(do ~@body)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Olical Olical merged commit b8dd63c into Olical:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants