Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markers (start and end) to trip plans on map #671

Closed
barbeau opened this issue Aug 18, 2016 · 1 comment
Closed

Add markers (start and end) to trip plans on map #671

barbeau opened this issue Aug 18, 2016 · 1 comment

Comments

@barbeau
Copy link
Member

barbeau commented Aug 18, 2016

Summary:

Currently trip plans are just lines on the map:

image

IMHO, this makes it difficult to tell which end is the origin or destination, and also makes it difficult to tell where there is a transition between two routes, or between transit and walking.

I'd like to add markers to make the origin/destination easier to distinguish, and markers to indicate mode transitions.

Here's how the markers look in OpenTripPlanner Android:

image

Here's how the markers look in Google Maps (left is using real-time location as origin, right is using a static location for origin):

image

I like the Google Maps approach for the origin/destination, with the origin as a circle (gray if static, blue if real-time), and the classic red marker for destination.

For mode transitions, something like OTP Android may work. We should use material design icons, though.

@barbeau barbeau added this to the v2.1.x milestone Aug 18, 2016
@barbeau barbeau changed the title Add markers (destination and mode transition) to trip plans Add markers (destination and mode transition) to trip plans on map Aug 18, 2016
@barbeau barbeau closed this as completed in 0cac62a Feb 8, 2017
@barbeau barbeau changed the title Add markers (destination and mode transition) to trip plans on map Add markers (start and end) to trip plans on map Feb 8, 2017
@barbeau
Copy link
Member Author

barbeau commented Feb 8, 2017

I've added simple start/end markers in 0cac62a, so it now looks like:

image

I opened #755 to deal with mode transitions, etc.

barbeau added a commit to acrown-msft/onebusaway-android that referenced this issue Mar 2, 2017
acrown-msft added a commit to acrown-msft/onebusaway-android that referenced this issue Jan 4, 2018
* Adding social functionality

Running OBA style checker

* Navigation Drawer expand/collapse chevron recolored and expanded clickable area to include entire row

* Lowered min sdk version to 9 and moved check for social functionality to Utils

* Updated build config name for Embedded Social api key and added field to agency x & y build flavors

* Updated Navigation drawer fragment to get shared preferences from the application class

* Remove extra margin from top and bottom of navigation drawer

* Updated navigation drawer fragment to include only relevant social items

* Removed unused navigation drawer items from Home Activity

* Undo changes removing margins from navdrawer

* Fixed bug where Action Bar did not appear in ArrivalsListActivity

* Moved non-UI strings to DoNotTranslate

* Updated comment bubble to be material design icon

* Removing unncessary Embedded Social search configurations

* Updating SDK version to fix google auth

* Fixed a bug where 'University Area Transit Center' would briefly show when loading a social fragment

* Use OBA theme color in SDK progress bars

* Fixed bug where Pins navdrawer item would appear below the social overflow when the plan trip item was displayed

* Updating Embedded Social server url to point to production instance

* Updated Google authentication endpoint and removed unnecessary string resource

* Fixed bug when opening discussion from ArrivalsListActivity

* Update What's New for embedded social

* Bump version to prepare for release

* Jump several versionCodes over current master to allow for additional production releases which alpha is still deployed.

* Fix unit test compilation issue

* Updated embedded social library package name in proguard rules

* Change to RealtimeService: Intent for BroadcastReceiver in Android 7.0 should only have primitive types in Bundle (ie no get/set Serializable).

Fix duplicate calls to RealtimeService

* Ensure correct itinerary is selected when app is backgrounded and resumed.

* Fix OneBusAway#747 - Only show trip plan report button if we get a server response

* Also change dialog message to "check Internet connection"

* Fix OneBusAway#671 - Add trip plan start/end markers

* Improve trip plan notification text

* Make it clearer what is happening when notifiying user that a better itinerary was found, or that their trip had a significant schedule deviation change since when they first planned the trip

* Updating ES version for google play store

* Bump versionCode

We burned versionCode 80 - as after we uploaded and submitted the APK Google rejected it with the following vulnerability message:

------
onReceivedSslError

Detected in APK 80
Your app is using an unsafe implementation of WebViewClient.onReceivedSslError handler. Please see this Google Help Center article for details, including the deadline for fixing the vulnerability.
Vulnerable classes:
•	com.microsoft.live.AuthorizationRequest$OAuthDialog$AuthorizationWebViewClient
------

And we can't upload another APK with versionCode 80, so we'll bump to 81.

* Bump plugins for Android Studio 2.3

* Temporary workaround for OneBusAway#720 - don't run unit tests on Travis

* Added configuartions which hide social search options and the topic gallery view

* Update SDK version and add configurations required for push notifications

* Removing unnecessary interface and simply overwriting the SDK's color attribute

* Updating colors to overwrite SDK values and removing unnecessary objects previously used for coloring the UI

* Added analytics to track interactions with the social UI elements

* Updating social analytics names and values

* Updating SDK version and reverting version information

* Fix OneBusAway#770 - Get release password via dialog when Gradle runs as daemon

* If gradle is not running as a daemon, get key/keystore password via command line input
* Update README for current release process

* Bump version number to prepare for release

* Fix OneBusAway#697 - Allow users to opt out of "Location not enabled" dialog

* Update to OneBusAway#697 - Allow users to opt out of "Location not enabled" dialog

* Include Amazon build variant - somehow this didn't get committed with 98135b6

* Updating SDK version to exclude ms auth library

* Bump version number to prepare for release

* Updating config to exclude user profile tabs which showcase user created topics

* Removing margins from navigation drawer list. OBA UI is unaffected but the navigation drawer in social activities loses the extra whitespace

* Apply multidex removal to embedded-social branch

* Enable Facebook auth

* Update Embedded Social SDK version

* Enabling Microsoft auth

* Bump version for next release

* Update What's New

* Remove dexOptions from build.gradle

* Fixing DB update to avoid failure cases and log attempts to add duplicate columns

* Removing unnecessary imports from ObaProvider

* Removing unnecessary import from HomeActivity

* Update SDK version and proguard rules to avoid any DEX issues

* Removing dependency on ES activities

* Updating SDK version to use comment feed fragment

* Updating config to remove user relations since users cannot post topics

* Updating Nevigation Drawer fragment behavior when resuming a paused activity or navigating via the back button

* Update behavior plan trip activity's software back button to handle ES activities

* Move social options menu to the OBA settings page

* Pull newest version of ES SDK

* Remove navigation drawer from the ES Options activity

* Allow HomeActivity to remain on the back stack when the Help nav drawer option is invoked from an ES activity

* Correct nav drawer highlight when a user selects the help option while in an ES activity

* Fixed bug where Embedded Social funtion is called without checking if social is enabled

* Fix issue where OBA failed to build if EmbeddedSocialApiKey was missing

* Added comments to functions handling the ES API key and fixed a method name in EmbeddedSocialUtils

* Use PrimaryThemeDark to color the status bar in ES activities

* Bump version to prepare for release

* Updating SDK version to fix spacing in the action bar

* Update SDK version for updated Google auth flow

* Include layout for navdrawer separator rather than copy it

* Update copyright on files authored by Microsoft

* Add copyright to files touched by Microsoft

* Updating contributors file

* Update the social button to properly handle the fragment back stack and move ES specific logic to EmbeddedSocialUtils

* Update copyright

* Fix copyright header

* Fix copyright header

* Fix copyright header

* Update AndroidManifest.xml

* Remove extra whitespace

* Fix copyright header

* Fix copyright header

* Fix copyright header

* Fix copyright header

* Fix copyright header

* Fix copyright header

* Fix copyright headers

* Update strings for toasts when signing in or out and when viewing teh settings page.  Hide social settings if ES is not enabled

* Update toast text for creating user

* Update SDK version

* Fix bugs related to Navigation drawer

* Factor the callback logic for social activities into a named class

* Display the pin feed as a fragment rather than as an activity

* Display the popular and recent activity feeds as fragments rather than activities

* Replace the NavDrawer with an Up arrow in the SignIn activity

* Reorder and refactor references to the Popular Feed fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant