Embedded social fragments #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running OBA style checker
…kable area to include entire row
… to agency x & y build flavors
… application class
… when loading a social fragment
…rflow when the plan trip item was displayed
* Jump several versionCodes over current master to allow for additional production releases which alpha is still deployed.
…0 should only have primitive types in Bundle (ie no get/set Serializable). Fix duplicate calls to RealtimeService
…rver response * Also change dialog message to "check Internet connection"
* Make it clearer what is happening when notifiying user that a better itinerary was found, or that their trip had a significant schedule deviation change since when they first planned the trip
… settings page. Hide social settings if ES is not enabled
…usaway-android into embedded-social
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTest connectedObaAmazonDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.