-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anne fix hovering in dark mode subtask get white issue for WBS tasks #2773
Conversation
…in the background anymore
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the PR and everything works as expected.
PR.vid.47.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anne, I have tested your PR, and it works great. I do not see any issues with your changes.
Recording.2024-10-12.104240.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7c50471
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked in dark mode, the hover effect works as expected with no background color issues. Approving the PR.
anne-PR.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
660fae0
Hi @NK3101 @CodewithKoushica! Thanks for the review. The issue you mentioned is not in the scope of this PR. I believe this issue has existed beforehand. You can comment in the bug document to raise a bug. Thank you. |
Description
Addressing issue raised by Shrinivas Patil while testing a previous PR
Related PRS (if any):
This frontend PR is related to the development backend PR.
This frontend PR is an update to #2709, fixing the issue as described in the description above.
Main changes explained:
How to test:
Screenshots or videos of changes:
video1215154952.mp4
Note:
Include the information the reviewers need to know.