Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anne fix hovering in dark mode subtask get white issue for WBS tasks #2773

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Annezhang673
Copy link
Contributor

Description

Addressing issue raised by Shrinivas Patil while testing a previous PR
image

Related PRS (if any):

This frontend PR is related to the development backend PR.
This frontend PR is an update to #2709, fixing the issue as described in the description above.

Main changes explained:

  • Update file /HighestGoodNetworkApp/src/components/Projects/WBS/WBSDetail/wbs.css to include the scenario when there is on hover action in the dark mode, the background of the sub task remains dark, instead of white.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Other Links>Projects>Click WBS Icon
  6. Please refer to the above link on how to create WBS task and sub tasks. There are minor differences.
  7. Add task A , then proceed to add sub task B, then proceed to add sub task C.
  8. Check if under darkmode, when hovering above the subtasks, the background did not turn white, instead it should remain dark and the texts should be clear and recognizable

Screenshots or videos of changes:

video1215154952.mp4

Note:

Include the information the reviewers need to know.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 660fae0
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/672e786a6fec6d000827ea10
😎 Deploy Preview https://deploy-preview-2773--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.47.mp4

vishavk1992
vishavk1992 previously approved these changes Oct 10, 2024
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and everything working as expected.

Screenshot 2024-10-10 195651

@chu-ziyu chu-ziyu self-requested a review October 12, 2024 00:51
chu-ziyu
chu-ziyu previously approved these changes Oct 12, 2024
Copy link
Contributor

@chu-ziyu chu-ziyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in dark mode and everything worked as expected.
Screenshot 2024-10-11 at 5 52 25 PM

@ShreyaLaheri
Copy link

Hi - I am on the current branch and followed the steps but I don't see the change
image

Copy link

@shivansh-nathani shivansh-nathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the code and the bug is fixed.
Screenshot 2024-10-11 at 10 56 13 PM

Nahiyan-16
Nahiyan-16 previously approved these changes Oct 12, 2024
Copy link
Contributor

@Nahiyan-16 Nahiyan-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anne, I have tested your PR, and it works great. I do not see any issues with your changes.

Recording.2024-10-12.104240.mp4

aaryaneil
aaryaneil previously approved these changes Oct 13, 2024
Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and the changes work as expected in darkmode and the hover functionality works as expected.
Just a minor change in the hover the
tag is still visible.

Screenshot 2024-10-13 at 3 36 09 AM Screenshot 2024-10-13 at 3 36 16 AM

@pallavithorat
Copy link

The PR is working as expected, with task A, subtask B, and subtask C added successfully. Under dark mode, hovering over the subtasks keeps the background dark, and the text remains clear and recognizable, without turning white.
PR#2773

shashankhv
shashankhv previously approved these changes Oct 21, 2024
Copy link

@shashankhv shashankhv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in dark mode, the hover effect works as expected with no background color issues. Approving the PR.

anne-PR.webm

Copy link

@CodewithKoushica CodewithKoushica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dark mode, and the hover effect works well with no background color issues. However, the tooltip currently displays HTML tags. Please update the tooltip to remove the tags.
Screenshot 2024-10-22 at 5 34 20 PM

samarth9201
samarth9201 previously approved these changes Oct 25, 2024
Copy link
Contributor

@samarth9201 samarth9201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR, works as expected.

image

Copy link

@NK3101 NK3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR in dark mode, the hover effect functions as expected. However, there's a hover text currently displaying HTML tags for sub-tasks.

Screenshot 2024-10-25 at 9 29 31 PM

Copy link

@Muhideenthegreat Muhideenthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification:

Everything in this PR works as expected

Screenshot 2024-10-26 at 2 38 46 PM

@Annezhang673
Copy link
Contributor Author

Hi @NK3101 @CodewithKoushica! Thanks for the review. The issue you mentioned is not in the scope of this PR. I believe this issue has existed beforehand. You can comment in the bug document to raise a bug. Thank you.

@one-community one-community merged commit e51006a into development Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.