Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ogc 1160 formcode warning for empty fieldsets #1444

Merged

Conversation

Tschuppi81
Copy link
Contributor

Form: Raise error for empty field sets

TYPE: Feature
LINK: ogc-1160

Copy link

linear bot commented Jul 18, 2024

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (a4f76d7) to head (66cc10b).
Report is 2 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
src/onegov/form/errors.py 88.46% <100.00%> (+1.50%) ⬆️
src/onegov/form/parser/core.py 97.67% <100.00%> (+0.01%) ⬆️
src/onegov/form/parser/form.py 94.08% <100.00%> (ø)
src/onegov/form/validators.py 89.62% <75.00%> (-0.22%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f76d7...66cc10b. Read the comment docs.

Copy link
Member

@Daverball Daverball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's a pitfall about the current placement of the check.

src/onegov/form/parser/core.py Outdated Show resolved Hide resolved
@Tschuppi81 Tschuppi81 merged commit 11be9de into master Jul 19, 2024
14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-1160-formcode-warning-for-empty-fieldsets branch July 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants