Feature/ogc 1160 formcode warning for empty fieldsets

src/onegov/form/errors.py

@@ -29,6 +29,11 @@ def __init__(self, line: int):
         self.line = line
 
 
+class EmptyFieldsetError(FormError):
+    def __init__(self, field_name: str):
+        self.field_name = field_name
+
+
 class FieldCompileError(FormError):
     def __init__(self, field_name: str):
         self.field_name = field_name

src/onegov/form/locale/de_ch/LC_MESSAGES/onegov.form.po

@@ -175,6 +175,12 @@ msgstr ""
 "Ein Minimalpreis kann nur gesetzt werden, wenn mindestens ein "
 "kostenpflichtiges Feld definiert ist."
 
+#, python-format
+msgid "The '{label}' group is empty and will not be visible. Either "
+"remove the empty group or add fields to it."
+msgstr "Die Gruppe '{label}' ist leer und wird nicht sichtbar sein. "
+"Entweder entfernen Sie die leere Gruppe oder fügen Felder hinzu."
+
 #, python-format
 msgid ""
 "Invalid field type for field '{label}'. For filters only 'select' or "

src/onegov/form/locale/fr_CH/LC_MESSAGES/onegov.form.po

@@ -174,6 +174,12 @@ msgstr ""
 "Un total de prix minimum ne peut être paramétré que si au moins un champ "
 "payant est défini."
 
+#, python-format
+msgid "The '{label}' group is empty and will not be visible. Either "
+"remove the empty group or add fields to it."
+msgstr "Le groupe '{label}' est vide et ne sera pas visible. Supprimez le "
+"groupe vide ou ajoutez des champs."
+
 #, python-format
 msgid ""
 "Invalid field type for field '{label}'. For filters only 'select' or "

src/onegov/form/locale/it_CH/LC_MESSAGES/onegov.form.po

@@ -172,6 +172,13 @@ msgstr ""
 "È possibile impostare un prezzo minimo totale solo se è definito almeno un "
 "campo prezzo."
 
+#, python-format
+msgid "The '{label}' group is empty and will not be visible. Either "
+"remove the empty group or add fields to it."
+msgstr ""
+"Il gruppo '{label}' è vuoto e non sarà visibile. Rimuovere il gruppo vuoto "
+"o aggiungere campi."
+
 #, python-format
 msgid ""
 "Invalid field type for field '{label}'. For filters only 'select' or "

src/onegov/form/parser/core.py

@@ -1188,6 +1188,8 @@ def parse_formcode(
             parse_field_block(block, field_classes, used_ids, fs)
             for block in (fieldset[label] or ())
         ]
+        if not fs.fields:
+            raise errors.EmptyFieldsetError(label)
 
         fieldsets.append(fs)
 

src/onegov/form/validators.py

@@ -11,7 +11,8 @@
 from dateutil.relativedelta import relativedelta
 from mimetypes import types_map
 from onegov.form import _
-from onegov.form.errors import DuplicateLabelError, InvalidIndentSyntax
+from onegov.form.errors import (DuplicateLabelError, InvalidIndentSyntax,
+                                EmptyFieldsetError)
 from onegov.form.errors import FieldCompileError
 from onegov.form.errors import InvalidFormSyntax
 from onegov.form.errors import MixedTypeError
@@ -189,6 +190,9 @@
         "A minimum price total can only be set if at least one priced field "
         "is defined."
     )
+    empty_fieldset = _(
+        "The '{label}' group is empty and will not be visible. Either remove "
+        "the empty group or add fields to it.")
 
     def __init__(
         self,
@@ -218,6 +222,11 @@
             raise ValidationError(
                 field.gettext(self.indent).format(line=exception.line)
             ) from exception
+        except EmptyFieldsetError as exception:
+            raise ValidationError(
+                field.gettext(self.empty_fieldset).format(
+                    label=exception.field_name)
+            ) from exception
         except DuplicateLabelError as exception:
             raise ValidationError(
                 field.gettext(self.duplicate).format(label=exception.label)

tests/onegov/form/test_parser.py

@@ -1055,7 +1055,7 @@ def test_normalization():
     # no indent check while parsing
     ('', False, False),
 ])
-def test_indentation_error_while_parsing(indent, indent_check, shall_raise):
+def test_indentation_error(indent, indent_check, shall_raise):
     # wrong indent see 'Telefonnummer'
     text = dedent(
         """
@@ -1077,3 +1077,40 @@ def test_indentation_error_while_parsing(indent, indent_check, shall_raise):
             parse_formcode(text, enable_indent_check=indent_check)
         except InvalidIndentSyntax as e:
             pytest.fail('Unexpected exception {}'.format(type(e).__name__))
+
+
+def test_empty_fieldset_error():
+    with pytest.raises(errors.EmptyFieldsetError) as e:
+        parse_form('\n'.join((
+            "# Section 1",
+            "# Section 2",
+            "First Name *= ___",
+            "Last Name *= ___",
+            "E-mail *= @@@"
+        )))
+
+    assert e.value.field_name == 'Section 1'
+
+    with pytest.raises(errors.EmptyFieldsetError) as e:
+        parse_form('\n'.join((
+            "# Section 1",
+            "First Name *= ___",
+            "Last Name *= ___",
+            "# Section 2",
+            "E-mail *= @@@",
+            "# Section 3",
+        )))
+
+    assert e.value.field_name == 'Section 3'
+
+    with pytest.raises(errors.EmptyFieldsetError) as e:
+        parse_form('\n'.join((
+            "# Section 1",
+            "First Name *= ___",
+            "Last Name *= ___",
+            "# Section 2",
+            "# Section 3",
+            "E-mail *= @@@",
+        )))
+
+    assert e.value.field_name == 'Section 2'