-
Notifications
You must be signed in to change notification settings - Fork 368
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2034 from OneSignal/fix/event-producer-thread-safe
[Fix] thread safety with EventProducer's fire events
- Loading branch information
Showing
2 changed files
with
54 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
OneSignalSDK/onesignal/core/src/test/java/com/onesignal/common/EventProducerTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package com.onesignal.common | ||
|
||
import com.onesignal.common.events.EventProducer | ||
import io.kotest.core.spec.style.FunSpec | ||
import kotlin.concurrent.thread | ||
|
||
class EventProducerTest : FunSpec({ | ||
|
||
fun modifyingSubscribersThread(eventProducer: EventProducer<Boolean>): Thread { | ||
return thread(start = true) { | ||
repeat(10_000) { | ||
eventProducer.subscribe(true) | ||
eventProducer.unsubscribe(true) | ||
} | ||
} | ||
} | ||
|
||
test("fire is thread safe") { | ||
val eventProducer = EventProducer<Boolean>() | ||
val modifyingSubscribersThread = modifyingSubscribersThread(eventProducer) | ||
|
||
repeat(10_000) { | ||
eventProducer.fire { } | ||
} | ||
|
||
modifyingSubscribersThread.join() | ||
} | ||
|
||
test("suspendingFire is thread safe") { | ||
val eventProducer = EventProducer<Boolean>() | ||
val modifyingSubscribersThread = modifyingSubscribersThread(eventProducer) | ||
|
||
repeat(10_000) { | ||
eventProducer.suspendingFire { } | ||
} | ||
|
||
modifyingSubscribersThread.join() | ||
} | ||
|
||
test("hasSubscribers is thread safe") { | ||
val eventProducer = EventProducer<Boolean>() | ||
val modifyingSubscribersThread = modifyingSubscribersThread(eventProducer) | ||
|
||
repeat(10_000) { | ||
eventProducer.hasSubscribers | ||
} | ||
|
||
modifyingSubscribersThread.join() | ||
} | ||
}) |