[Fix] thread safety with EventProducer's fire events #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinliu9508
approved these changes
Mar 22, 2024
nan-li
approved these changes
Mar 28, 2024
jkasten2
force-pushed
the
fix/op-repo-fix-keeping-cpu-awake
branch
from
60a4280
to
fd60e70
Compare
Test confirmed java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 fails on .toList() before change.
jkasten2
force-pushed
the
fix/event-producer-thread-safe
branch
from
af70434
to
d798815
Compare
Merged
This was referenced Apr 10, 2024
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes bug where
EventProducer.firecan throw when another thread callsEventProducer.remove.Details
Motivation
SDK should be stable and not cause crashes.
Related Issues
Fixes #2007
Scope
Only affects
EventProducer.Testing
Unit testing
Added a new
EventProducerTest.Manual testing
Ran on an Android 6 emulator ensuring it subscribes for push.
Affected code checklist
Checklist
Overview
Testing
Final pass
Code is as readable as possible.
I have reviewed this PR myself, ensuring it meets each checklist
This change is