Fix Displaying IAMs past end time #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change involves reading in end_time from JSON when creating an IAM so that we can decide to not show the IAM (Cached case) if the IAM should be finished. The date comes in iso8601 format.
Jeasmine
reviewed
Dec 22, 2020
| return null; | ||
| } | ||
|
|
||
| SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", Locale.US); |
There was a problem hiding this comment.
can we put this on a constant?
There was a problem hiding this comment.
Can we have the same iOS object OneSignal/OneSignal-iOS-SDK#841 (comment) in here?
There was a problem hiding this comment.
created a OneSignalSimpleDateFormatter class with a static method to get the iso8601 format
Jeasmine
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change involves reading in end_time from JSON when creating an IAM
so that we can decide to not show the IAM (Cached case) if the IAM
should be finished. The date comes in iso8601 format.
This change is