Fix showing IAMS past stop time #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change involves reading in end_time from JSON when creating an IAM so that we can decide to not show the IAM (Cached case) if the IAM should be finished. The date comes in iso8601 format so I added a NSDateFormatter category with that format to easily retrieve it. Note we cannot use the Apple provided iso8601 date formatter class until we drop iOS 9 support.
Jeasmine
approved these changes
Dec 22, 2020
|
|
||
| if (json[@"end_time"] && [json[@"end_time"] isKindOfClass:[NSString class]]) { | ||
| NSString *stringEndTime = json[@"end_time"]; | ||
| NSDateFormatter *dateFormatter = [NSDateFormatter iso8601DateFormatter]; |
There was a problem hiding this comment.
can we have this object on Android too?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change involves reading in end_time from JSON when creating an IAM
so that we can decide to not show the IAM (Cached case) if the IAM
should be finished. The date comes in iso8601 format so I added a
NSDateFormatter category with that format to easily retrieve it.
Note we cannot use the Apple provided iso8601 date formatter class until
we drop iOS 9 support.
This change is