[User model] [Fix] macOS Safari prompting and subscribing #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is no longer needed as the session manager and model repo handle these checks. The original motivation to remove this is to address a macOS Safari notification permission prompting issue where you can't await on I/O, otherwise the prompting is flagged not done from an end-user interaction. The isPushNotificationsEnabled() does disk I/O which we removed in this commit.
Since we no longer support the os.tc workaround there is no need to check the the indexDb for user preferences. Native notification permission status is checked later making this unnecessary as well from normal HTTPS setups.
Corrected missing logic changes that PR #1002 introduced in main but were not accounted for in the last rebase. Tested on masOS 13.3.1 with Safari 16.4 to confirm the browser subscribes to push correctly with the backend.
rgomezp
approved these changes
Jul 26, 2023
| /* | ||
| Within the same page navigation (the same session), do not register for | ||
| push if the user is already subscribed, otherwise the user will have its | ||
| session count incremented on each page refresh. However, if the user is |
There was a problem hiding this comment.
Did you confirm the session count is not incrementing even after the refresh? What is the impact on other browsers? From first glance it doesn't appear this code was Safari-specific.
There was a problem hiding this comment.
I updated the "Tests" section in this PR to provide more details on this.
Base automatically changed from
user-model/fix-user-property-updates-before-subscription-create
to
user-model/v1
July 28, 2023 18:38
jkasten2
deleted the
user-model/fix-macos-safari-prompting-and-subscribing
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Fix macOS Safari error "Push notification prompting can only be done from a user gesture." when prompting for notification permission and registering for push.
Details
window.safari.pushNotification.requestPermission()) doesn't allow awaiting for any I/O which was causing the prompting error. Commits:Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is