Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User model] [Fix] macOS Safari prompting and subscribing #1062

Merged
merged 4 commits into from
Jul 28, 2023
Merged

[User model] [Fix] macOS Safari prompting and subscribing #1062

merged 4 commits into from
Jul 28, 2023

Commits on Jul 26, 2023

  1. remove no longer needed first page view check 

    This check is no longer needed as the session manager and model repo
handle these checks.

The original motivation to remove this is to address a macOS Safari
notification permission prompting issue where you can't await on I/O,
otherwise the prompting is flagged not done from an end-user
interaction. The isPushNotificationsEnabled() does disk I/O which we
removed in this commit.
    @jkasten2
    jkasten2 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b724a62 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary optedOut check 

    Since we no longer support the os.tc workaround there is no need to
check the the indexDb for user preferences. Native notification
permission status is checked later making this unnecessary as well from
normal HTTPS setups.
    @jkasten2
    jkasten2 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    04c97ae View commit details
    Browse the repository at this point in the history

  3. fix safari legacy push token detection 

    Corrected missing logic changes that PR #1002 introduced in main but
were not accounted for in the last rebase.

Tested on masOS 13.3.1 with Safari 16.4 to confirm the browser
subscribes to push correctly with the backend.
    @jkasten2
    jkasten2 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    03d5989 View commit details
    Browse the repository at this point in the history

  4. updated Safari 16 comments

    @jkasten2
    jkasten2 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6ede032 View commit details
    Browse the repository at this point in the history