Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS null callback fix for setExternalUserId #1141

Merged
merged 2 commits into from
Jan 11, 2021
Merged

iOS null callback fix for setExternalUserId #1141

merged 2 commits into from
Jan 11, 2021

Commits on Jan 11, 2021

  1. iOS null callback fix for setExternalUserId 

    Motivation: we want to make sure that the `setExternalUserId` works for iOS even if no callback is passed. Thus, we are re-adding the default callback but for iOS only. 

Note: for Android we want it to be nullable temporarily as a workaround for the current issue of the same callback firing multiple times (crashes) due to the `onSuccess` triggering once per channel.

Note: in the future, we intend to make argument non-nullability or nullability consistent across both platforms.
    @rgomezp
    rgomezp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    dc2acbb View commit details
    Browse the repository at this point in the history

  2. 4.0.3 Release Commit 

    Includes patch for `setExternalUserId` iOS null callback crash
    @rgomezp
    rgomezp committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    d9b5bf9 View commit details
    Browse the repository at this point in the history