iOS null callback fix for setExternalUserId
#1141
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: we want to make sure that the `setExternalUserId` works for iOS even if no callback is passed. Thus, we are re-adding the default callback but for iOS only. Note: for Android we want it to be nullable temporarily as a workaround for the current issue of the same callback firing multiple times (crashes) due to the `onSuccess` triggering once per channel. Note: in the future, we intend to make argument non-nullability or nullability consistent across both platforms.
Includes patch for `setExternalUserId` iOS null callback crash
jkasten2
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we want to make sure that the
setExternalUserIdworks for iOS even if no callback is passed. Thus, we are re-adding the default callback but for iOS only.Note: for Android we want it to be nullable temporarily as a workaround for the current issue of the same callback firing multiple times (crashes) due to the
onSuccesstriggering once per channel.Note: in the future, we intend to make argument non-nullability or nullability consistent across both platforms.