Remove default callback function from removeExternalUserId
#1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. It's been more than 2 weeks. Am I missing anything to make it to be reviewed? cc: @rgomezp |
|
Thanks for sharing your findings @torufuruya, my colleagues are working on other projects so I'll take a look at this PR. |
|
I tested this and it is fine. If no callback is given, the native code just won't invoke it. |
nan-li
requested changes
Nov 9, 2021
nan-li
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having this issue even in version
4.1.0. I looked into the code and probably found out the cause of the crash.To address the workaround for the above issue the below PRs are created before, but I guess it should also be applied to
removeExternalUserIdas it also defines the default empty callback function in it and it just calls thesetExternalUserIdwith an empty user ID internally.#1136 #1141
This change is