Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Feign] Add http status to feign result #10583

Conversation

hugo-ma-alves
Copy link
Contributor

To improve the previous PR #10507.

This PR adds the Http status code to the feign response.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@hugo-ma-alves hugo-ma-alves changed the title Add http status to feign result [Java][Feign] Add http status to feign result Oct 12, 2021

public int getStatus(){
return status;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugo-ma-alves can we make HttpResponse look more like ApiResponse ?

The goal is to make it consistent across different Java http library.

(in other words, I suggest we rename HttpResponse to ApiResponse)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion.
I refactored the templates to rename the HttpResponse to ApiResponse, and to keep it coherent I also renamed the JacksonResponseDecoder to ApiResponseDecoder.

@hugo-ma-alves
Copy link
Contributor Author

hugo-ma-alves commented Oct 17, 2021

I noticed that the jersey2 sample is not compiling in circleCi.

Not sure if it is related with this PR, i believe I haven't changed anything that could impact jersey2 generator.
It looks that there is an import missing in the jersey2/pojo.mustache?

I checked the history but I don't see any recent change either on the pojo.mustache or the JSON.mustache. But there was a recent rollback related with the jersey 2 generator. I did a quick test by adding the missing import and re-generated the samples. If you want you can take a look or merge it if it is ok https://github.com/hugo-ma-alves/openapi-generator/tree/bugfix/missing-jersey2-import

Just had to update my branch with the latest master changes 🤷‍♂️

@wing328 wing328 added this to the 5.3.0 milestone Oct 18, 2021
@wing328
Copy link
Member

wing328 commented Oct 18, 2021

LGTM

@wing328 wing328 merged commit ff286aa into OpenAPITools:master Oct 18, 2021
@hugo-ma-alves hugo-ma-alves deleted the feature/add-http-status-to-feign-result branch October 18, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants