-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Feign] Add http status to feign result #10583
Merged
wing328
merged 11 commits into
OpenAPITools:master
from
hugo-ma-alves:feature/add-http-status-to-feign-result
Oct 18, 2021
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a187b11
Add .circleci/config.yml
hugo-ma-alves 10eef40
Merge branch 'OpenAPITools:master' into master
hugo-ma-alves 069099a
Merge branch 'OpenAPITools:master' into master
hugo-ma-alves dd7c9b9
Add Http status to the feign response wrapper
hugo-ma-alves 42b34c1
Add Http status to the feign response wrapper
hugo-ma-alves 9cd9b9d
Add Http status to the feign response wrapper
hugo-ma-alves 6a0162b
Add Http status to the feign response wrapper
hugo-ma-alves ab74dcf
Merge branch 'feature/add-http-status-to-feign-result' of github.com:…
hugo-ma-alves 8a6718f
Merge branch 'OpenAPITools:master' into feature/add-http-status-to-fe…
hugo-ma-alves 25ff919
Rename HttpResponse to ApiResponse
hugo-ma-alves 2e7952e
Merge branch 'OpenAPITools:master' into feature/add-http-status-to-fe…
hugo-ma-alves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugo-ma-alves can we make HttpResponse look more like ApiResponse ?
The goal is to make it consistent across different Java http library.
(in other words, I suggest we rename HttpResponse to ApiResponse)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
I refactored the templates to rename the HttpResponse to ApiResponse, and to keep it coherent I also renamed the JacksonResponseDecoder to ApiResponseDecoder.