[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patouche
force-pushed
the
feature/2901-integrate-property-to-remove-json-nullable
branch
3 times, most recently
from
604e96f to
f28b704
Compare
Patouche
force-pushed
the
feature/2901-integrate-property-to-remove-json-nullable
branch
from
f28b704 to
2909c08
Compare
|
Hi here ! Any chance for a review or any other feedback ? If you disagree with changes made in this PR, I can correct them and update the PR or close the PR if you think it completely useless. I can also rebase the PR if you wish. Thanks a lot, |
|
@bbdouglas / @sreeshas / @jfiala / @lukoyanov / @cbornet / @jeff9finger / @karismann / @Zomzog / @lwlee2608 / @bkabrda Please review |
|
Just wanted to point out that William requested @Patouche to ping him on Slack so we can move this PR forward. I like the approach in the PR to optionally remove |
|
Hi @jimschubert , Sorry for the delay - I have other priorities this last days. Thanks for the reminder, |
Add a option for all java client and server to prevent usage of third party library (jackson-databind-nullable) which may be forbidden in some company Add samples for Vertx, Spring MVC, Spring Cloud, Feign and Play Upgrade dependencies for org.openapitools:jackson-databind-nullable
Patouche
force-pushed
the
feature/2901-integrate-property-to-remove-json-nullable
branch
from
af81748 to
83253d9
Compare
Patouche
force-pushed
the
feature/2901-integrate-property-to-remove-json-nullable
branch
from
248aa7d to
3ea0019
Compare
…json-nullable * master: [Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642) [php-slim4] Move config to a separate file (OpenAPITools#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309) Fix typescript-node generation when only models are generated (OpenAPITools#7127) update spring config to use java8 (OpenAPITools#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305) [Java] remove deprecated jackson classes (OpenAPITools#7304) Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274) [Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299) [Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267) [C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert
changed the title
|
I've resolved merge conflicts. I think this ready to merge as long as the concerns @wing328 raised in Slack are addressed. |
|
Thanks @jimschubert . Yes, I already did it last week but there was some new conflicts the next day. Thanks a lot. |
wing328
approved these changes
Aug 31, 2020
jimschubert
added a commit
that referenced
this pull request
Sep 2, 2020
* master: (89 commits) add structPrefix support to go-experimental (#7327) Add a link to SmartHR Tech Blog (#7324) Revert "Correct allOf with only one child schema (no discriminator)" (#7323) Correct allOf with only one child schema (no discriminator) (#6901) [Go]: Interface definitions for api functions (#5914) Update bug_report.md (#7320) update samples [Java][Client] Use java8 OffsetDateTime for clients (#7190) [java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154) [Spring Boot] update dependencies, mark java8 option as deprecated (#7306) Remove dot in golang type (#7307) [doc] Document usage of post-process file feature (#7315) fix http bear auth documentation for go clinets (#7312) [Extensions][Go][Java] Test x-auth-id-alias (#6642) [php-slim4] Move config to a separate file (#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309) Fix typescript-node generation when only models are generated (#7127) update spring config to use java8 (#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305) [Java] remove deprecated jackson classes (#7304) ...
jimschubert
added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
* master: (984 commits) add structPrefix support to go-experimental (OpenAPITools#7327) Add a link to SmartHR Tech Blog (OpenAPITools#7324) Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323) Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901) [Go]: Interface definitions for api functions (OpenAPITools#5914) Update bug_report.md (OpenAPITools#7320) update samples [Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190) [java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154) [Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306) Remove dot in golang type (OpenAPITools#7307) [doc] Document usage of post-process file feature (OpenAPITools#7315) fix http bear auth documentation for go clinets (OpenAPITools#7312) [Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642) [php-slim4] Move config to a separate file (OpenAPITools#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309) Fix typescript-node generation when only models are generated (OpenAPITools#7127) update spring config to use java8 (OpenAPITools#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305) [Java] remove deprecated jackson classes (OpenAPITools#7304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2901
Add a additional property to prevent adding the dependency
org.openapitools:jackson-databind-nullable:jarin the classpath. As explained on #2901, this dependency may be forbidden in some company.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Copy to technical committee for review Java code generation : @bbdouglas / @sreeshas / @jfiala / @lukoyanov / @cbornet / @jeff9finger / @karismann / @Zomzog / @lwlee2608 / @bkabrda