Fix typescript-node generation when only models are generated #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move export of all models to model/index.ts - move RequestFile definition to model/index.ts This fixes #7126
Make this backwards-compatible: - move `RequestFile` definition to `model/models.ts` - remove `model/index.ts` - re-export `RequestFile` from `api/apis.ts` - make generation of `ObjectSerializer` conditional
5 tasks
|
@sarumont please copy the technical comittee as soon as this PR is ready for review |
|
CCI build is still failing on some unrelated templates being out of date, but this PR is ready for review otherwise. CC @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov |
|
@sarumont please merge the most recent master |
|
@macjohnny Merged and pushed. |
macjohnny
reviewed
Aug 18, 2020
samples/server/petstore/php-symfony/SymfonyBundle-php/.openapi-generator/FILES
Outdated
Show resolved
Hide resolved
macjohnny
reviewed
Aug 24, 2020
...nt/petstore/typescript-angular-v10-provided-in-root/builds/with-npm/.openapi-generator/FILES
Outdated
Show resolved
Hide resolved
macjohnny
reviewed
Aug 26, 2020
macjohnny
reviewed
Aug 26, 2020
modules/openapi-generator/src/main/resources/typescript-node/models.mustache
Outdated
Show resolved
Hide resolved
Co-authored-by: Esteban Gehring <esteban.gehring@gmail.com>
jimschubert
added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
* master: (355 commits) [php-slim4] Move config to a separate file (OpenAPITools#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309) Fix typescript-node generation when only models are generated (OpenAPITools#7127) update spring config to use java8 (OpenAPITools#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305) [Java] remove deprecated jackson classes (OpenAPITools#7304) Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274) [Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299) [Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267) [C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302) add extension for hashable in swift5 (OpenAPITools#7300) [kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286) Add wbt-solutions logo (OpenAPITools#7298) [c-sharp] Fix default values with discriminator (OpenAPITools#7296) Add x-is-json to csharp generators (OpenAPITools#7293) Add raksul (OpenAPITools#7295) Add wbt-solutions as using company (OpenAPITools#7292) [C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285) [Java][clients] remove java.lang prefix from Object (OpenAPITools#6806) [core] Add x-is-free-form vendor extension (OpenAPITools#6849) ...
jimschubert
added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
…json-nullable * master: [Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642) [php-slim4] Move config to a separate file (OpenAPITools#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309) Fix typescript-node generation when only models are generated (OpenAPITools#7127) update spring config to use java8 (OpenAPITools#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305) [Java] remove deprecated jackson classes (OpenAPITools#7304) Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274) [Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299) [Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267) [C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert
added a commit
that referenced
this pull request
Sep 2, 2020
* master: (89 commits) add structPrefix support to go-experimental (#7327) Add a link to SmartHR Tech Blog (#7324) Revert "Correct allOf with only one child schema (no discriminator)" (#7323) Correct allOf with only one child schema (no discriminator) (#6901) [Go]: Interface definitions for api functions (#5914) Update bug_report.md (#7320) update samples [Java][Client] Use java8 OffsetDateTime for clients (#7190) [java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154) [Spring Boot] update dependencies, mark java8 option as deprecated (#7306) Remove dot in golang type (#7307) [doc] Document usage of post-process file feature (#7315) fix http bear auth documentation for go clinets (#7312) [Extensions][Go][Java] Test x-auth-id-alias (#6642) [php-slim4] Move config to a separate file (#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309) Fix typescript-node generation when only models are generated (#7127) update spring config to use java8 (#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305) [Java] remove deprecated jackson classes (#7304) ...
jimschubert
added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
* master: (984 commits) add structPrefix support to go-experimental (OpenAPITools#7327) Add a link to SmartHR Tech Blog (OpenAPITools#7324) Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323) Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901) [Go]: Interface definitions for api functions (OpenAPITools#5914) Update bug_report.md (OpenAPITools#7320) update samples [Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190) [java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154) [Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306) Remove dot in golang type (OpenAPITools#7307) [doc] Document usage of post-process file feature (OpenAPITools#7315) fix http bear auth documentation for go clinets (OpenAPITools#7312) [Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642) [php-slim4] Move config to a separate file (OpenAPITools#6971) [C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309) Fix typescript-node generation when only models are generated (OpenAPITools#7127) update spring config to use java8 (OpenAPITools#7308) [C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305) [Java] remove deprecated jackson classes (OpenAPITools#7304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7126
Manual testing has been performed with the minimal example provided in #7126. Current tests do not validate compilation, it seems (or #7126 would not exist). Please comment if such tests are desired.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterTODO:
minor