update ts-standard to 12.0.0

[musoke]

Steps to Reproduce

1. clone https://github.com/OpenBeta/open-tacos/
2. yarn install
3. yarn lint

Expected Behavior

package versions in package.json are mutually compatible.

Current Behavior

Get warning

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.9.5

Please only submit bug reports when using the officially supported version.

=============
Done in 9.33s.

Steps to fix

See also fix of similar issue in OpenBeta/openbeta-graphql#265

• change

  open-tacos/package.json

  Line 111 in 5be4774

  "ts-standard": "11.0.0",

  to version 12.0.0
• yarn install
• add and run yarn fix script as in https://github.com/musoke/openbeta-graphql/blob/0b193c16c880127a15171ae39459a0f48350da11/package.json#L60
• fix lints that can't be fixed automatically
• remove warning from readme:

  open-tacos/README.md

  Lines 125 to 127 in be2064a

  	### Typescript version warning
  	You might get build errors or be prompted to downgrade your version of TypeScript. This is due to the linter ```ts-standard``` using an older version of TypeScript. You can ignore the warning message.

[actuallyyun]

Amazing! I have been seeing this error as well, thanks for fixing it in the other repo! @musoke I could open a PR to fix it in this repo if this sounds good to you guys. @vnugent

[actuallyyun]

Hey @musoke after running yarn fix, I still got many linting errors, and most of them are about this rule:https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-misused-promises.md

Should I fix this error or ignore this rule?
There are also two errors about triple slashes :

  /Users/Ayun/webDev/OpenSource/open-tacos/next-env.d.ts:1:1: Do not use a triple slash reference for next, use `import` style instead. (@typescript-eslint/triple-slash-reference)
  /Users/Ayun/webDev/OpenSource/open-tacos/next-env.d.ts:2:1: Do not use a triple slash reference for next/image-types/global, use `import` style instead. (@typescript-eslint/triple-slash-reference)

But in the next-end.d.ts file, it writes

// NOTE: This file should not be edited
// see https://nextjs.org/docs/basic-features/typescript for more information.

[musoke]

This is probably a question for @vnugent, he wrote most of the code it still complains about

Triple slash imports: https://nextjs.org/docs/basic-features/typescript says that next-env.d.ts shouldn't be committed. @vnugent added it in f4c5c75 - is it ok to remove?

PS: probably best to time this carefully with the other incoming PRs, this touches enough files that it may conflict with a lot of them

[hawkishpolicy]

Is this still an active issue?

[musoke]

@actuallyyun had a partial fix. I don't know if she is still working on it or it is up for grabs.

[vnugent]

Triple slash imports: https://nextjs.org/docs/basic-features/typescript says that next-env.d.ts shouldn't be committed. @vnugent added it in f4c5c75 - is it ok to remove?

It was an oversight

is it ok to remove?

sure

[actuallyyun]

Sorry for the late reply. Hi @hawkishpolicy it is up for grabs! I started it but then I got many linting errors that require decisions beyond my ability. For instance, the no-misused-promises rule triggered a lot of errors all over the place. I am not sure if we should fix these errors or disable this rule. There are many other rules like this one.

[hawkishpolicy]

I don't know if I can do any better but I'll take a look if that's okay.

…

On Tue, May 16, 2023 at 12:22 PM Yun Ji ***@***.***> wrote: Sorry for the late reply. Hi @hawkishpolicy <https://github.com/hawkishpolicy> it is up for grabs! I started it but then I got many linting errors that require decisions beyond my ability. For instance, the no-misused-promises rule triggered a lot of errors all over the place. I am not sure if we should fix these errors or disable this rule. There are many other rules like this one. — Reply to this email directly, view it on GitHub <#787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5LHYZZVC44ACGJYI3YSTTTXGOST3ANCNFSM6AAAAAAXF22BSE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vnugent]

Added @hawkishpolicy to core-dev team commenting on the wrong issue

[hawkishpolicy]

What's the best way to check if the script worked?

I followed the instructions provided and I'm not getting any errors but i'd like to double check before I submit a PR

[musoke]

I would delete node_modules, yarn install again and try yarn lint. One of us can also try it once you make a PR.

[musoke]

@hawkishpolicy, did that work for you?

[hawkishpolicy]

Partly...I'm getting quite a few ES-Lint errors that I need to track down. Just been busy with contract work and family.

…

On Thu, Jun 8, 2023 at 2:45 PM nathan musoke ***@***.***> wrote: @hawkishpolicy <https://github.com/hawkishpolicy>, did that work for you? — Reply to this email directly, view it on GitHub <#787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5LHYZ5FXU5IATDP42JYZGTXKIMVTANCNFSM6AAAAAAXF22BSE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[musoke]

Ok, just wanted to make sure you're not stuck waiting for us.

[Ali7040]

please assign it to me. I want to work on it

[hawkishpolicy]

I still hit many errors after running the script and haven't had time to dig through the documentation. I'm more than happy to forgo this one.

…

On Mon, Jul 24, 2023, 10:57 AM Ali Haider ***@***.***> wrote: please assign it to me. I want to work on it — Reply to this email directly, view it on GitHub <#787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5LHYZYYDJQ7MBNYYGNSZQTXR2EMXANCNFSM6AAAAAAXF22BSE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vnugent]

@Ali7040 If you're working on this issue, please do a rebase with develop. I had to turn on Typescript strict mode for Issue #811 and ended up fixing / suppressing warnings in nearly 90 files.

[Ali7040]

I am already working on develop branch.

[Ali7040]

I just used yarn upgrade, and now everything works fine with "ts-standard": "11.0.0". Should I change it to "ts-standard": "12.0.0" or not?

[musoke]

@Ali7040, do you have a branch or draft PR you can share?

[Ali7040]

@musoke I haven't created a PR yet.

[Ali7040]

I just upgraded things, so it only changes the yarn.lock file. If you want, I can create a PR.

[musoke]

Please do

[Ali7040]

Check it out: #939

[vnugent]

@Ali7040 thanks for giving this issue a try. It turns out more complicated than I thought.