fix: upgrade ts-standard & fit errors

[vnugent]

---

name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''

---

What type of PR is this?(check all applicable)

• refactor
• feature
• bug fix
• documentation
• optimization
• other

Description

Related Issues

Issue #787

What this PR achieves

• upgrade ts-standard.
• fix misconfiguration in package.json which caused a rules not being checked
• fix all errors
• fix unit tests

Notes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
open-tacos	✅ Ready (Inspect)	Visit Preview	Sep 22, 2023 6:56pm

[musoke]

a huge PR!

[vnugent]

a huge PR!

It is! ts-standard linter was misconfigured in package.json so a lot of formatting issues fell through the crack. For example spaces are required between | operator

Promise<IUserProfile | null> 

or

[enapupe]

hi there, I was looking into some strange behaviour when uploading photos and noticed this PR seems to be the cause.
why did you replace await with void generally across the files?
the general uploader now does not wait (await!!) the upload to finish before giving the "upload complete" feedback.

[vnugent]

hi there, I was looking into some strange behaviour when uploading photos and noticed this PR seems to be the cause. why did you replace await with void generally across the files? the general uploader now does not wait (await!!) the upload to finish before giving the "upload complete" feedback.

Good catch. I was watching another user uploading photos earlier and saw similar behavior. In trying to fix linting errors I think this PR has introduced a bug.

[vnugent]

@enapupe thanks for reporting the bug. The app now waits for photo uploaded to be completed. Fixed in #990

[vnugent]

@all-contributors add @enapupe for bug

[allcontributors]

@vnugent

I've put up a pull request to add @enapupe! 🎉