Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download screen as lowercase screen name #1186

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Download screen as lowercase screen name #1186

merged 1 commit into from
Apr 11, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 6, 2024

closes #1178

@jmthomas jmthomas requested a review from ryanmelt April 6, 2024 21:11
Copy link

sonarqubecloud bot commented Apr 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (89c5d5d) to head (b89af04).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   74.98%   74.97%   -0.02%     
==========================================
  Files         595      595              
  Lines       43926    43923       -3     
  Branches      758      758              
==========================================
- Hits        32937    32930       -7     
- Misses      10906    10909       +3     
- Partials       83       84       +1     
Flag Coverage Δ
frontend 55.28% <ø> (-0.06%) ⬇️
python 82.98% <ø> (-0.02%) ⬇️
ruby-api 48.71% <ø> (ø)
ruby-backend 80.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit de2c18d into main Apr 11, 2024
24 checks passed
@jmthomas jmthomas deleted the screen_download branch April 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen download should use better name
2 participants