Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python web socket in Enterprise #1424

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Fix python web socket in Enterprise #1424

merged 1 commit into from
Jul 20, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jul 20, 2024

closes #1417

This is a bit of a hack because the "right way" as described here: https://websockets.readthedocs.io/en/stable/topics/authentication.html#machine-to-machine-authentication doesn't seem to work. I get alternating results of RuntimeError: Unauthorized followed by websockets.exceptions.ConnectionClosedOK: received 1000 (OK); then sent 1000 (OK).

@jmthomas jmthomas requested a review from ryanmelt July 20, 2024 16:32
Copy link

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.38%. Comparing base (1ee0440) to head (2eb7ab1).

Files Patch % Lines
openc3/lib/openc3/utilities/authentication.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
- Coverage   75.40%   75.38%   -0.02%     
==========================================
  Files         600      600              
  Lines       44700    44701       +1     
  Branches      777      777              
==========================================
- Hits        33705    33699       -6     
- Misses      10907    10914       +7     
  Partials       88       88              
Flag Coverage Δ
frontend 55.36% <ø> (-0.13%) ⬇️
python 83.96% <ø> (ø)
ruby-api 48.60% <ø> (ø)
ruby-backend 80.21% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit d408a09 into main Jul 20, 2024
26 checks passed
@jmthomas jmthomas deleted the python_ws_client branch July 20, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak/WebSocketApi Authentication Issues
2 participants