Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bearer optional in token to fix web_socket_api #1675

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ryanmelt
Copy link
Member

Fixes differences between Open Source and Enterprise

@ryanmelt ryanmelt requested a review from jmthomas October 28, 2024 23:43
Copy link

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to #1417

@ryanmelt
Copy link
Member Author

Yes #1417 was only a partial fix that broke open source.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (6cc33e6) to head (a08a038).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/script/web_socket_api.rb 0.00% 3 Missing ⚠️
openc3/lib/openc3/utilities/authentication.rb 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1675      +/-   ##
==========================================
+ Coverage   76.50%   76.53%   +0.02%     
==========================================
  Files         618      618              
  Lines       46933    46937       +4     
  Branches      850      850              
==========================================
+ Hits        35908    35922      +14     
+ Misses      10930    10920      -10     
  Partials       95       95              
Flag Coverage Δ
frontend 56.26% <ø> (+0.20%) ⬆️
python 83.96% <ø> (+<0.01%) ⬆️
ruby-api 48.74% <ø> (ø)
ruby-backend 82.52% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit 2425ff4 into main Oct 30, 2024
27 checks passed
@ryanmelt ryanmelt deleted the fix_bearer_in_web_socket_api branch October 30, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants