-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WEIS file readers and writers #2188
Add WEIS file readers and writers #2188
Conversation
@andrew-platt @mayankchetan @deslaughter it would be really useful for me right now to have the readers/writers available as an |
Add WEIS readers and writers
…ading and writing only
@mayankchetan I've done the following:
|
Thank you @cortadocodes, look good to me! |
@cortadocodes, This sounds like a reasonable plan. Thansk! |
Since there were lots of files added, then removed in the process of this PR, I suggest we do a squash merge to reduce the total storage required on the OpenFAST repository. |
PR to Octue repo: octue#6
|
…ters Removing Weis references in code + adding license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this!
Hi guys, do you know when |
Feature
This pull request copies the WEIS readers and writers for OpenFAST into the OpenFAST repo itself and makes them available via an
openfast_io
python package. The idea is for these readers and writers to be updated directly inline with OpenFAST development so they stay up to date and can be found and used by more people more easily.To avoid any breaking changes, I've copied over the python modules without any refactoring. Although I would have liked to add some unit tests, it's not in the scope of my work currently and I've been assured they work by users of OpenFAST. I've copied over the integration test from WEIS without running it or modifying it (apart from to update the paths to the test files).
Impacted areas of the software
openfast_io
is added under the top-level directoryopenfast_python
OpenFAST maintainers to-dos
PyPI
openfast_io
python package can be installed withpip
pyproject.toml
pyproject.toml
are correct (I checked the commits for theaeroelasticse
directory in WEIS to get the list I've included, but if you keep it in the repo root, you might want to add some more people)pyproject.toml
toopenfast_io
3.5.4
Other
FAST_writer.py
IEC_CoeherentGusts.py
create_output_vars.py