-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to openfast_io to match current dev branch API #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankchetan
changed the title
Updates to opencast_io to match current dev branch API
Updates to openfast_io to match current dev branch API
Aug 7, 2024
I haven't checked through the code, but just noticed there is a new input in the AeroDyn input file that wasn't included in any of the regression tests yet (adding that line to all AD input files in PR #1295).
|
2 tasks
This reverts commit 00db7af.
Ready for merge @andrew-platt, please squash commits :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is NOT ready to merge until TODOs below are cleared.
Feature or improvement description
Updates to the
openfast_io
library to match the currentdev
branch API. Once merged, will provide OpenFAST users with an up-to-date library that they can import to read/write OpenFAST files. This follows thefst_vt
nested dictionary structure developed underWEIS
and heavily borrows code from there.This library is currently limited to
OpenFAST
and does not work withFAST.Farm
or any of the module drivers.Related PRs: #2333, #2188
Related issue, if one exists
#2233, #2261, #1851
Impacted areas of the software
openfast_io
Additional supporting information
Test results, if applicable
pytest
added to span most OpenFAST input files (drivers not included). Based on @andrew-platt comments in #2233, need to introduce automated testing.TODO:
openfast_io
since most NREL tools likeWEIS
andWISDEM
prefer it.Poetry
fileWe will continue usingPoetry
old API
warning thrown by AD15APIs to upgrade before merge:
SoilDyn -- soil dynamics module #986