-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor openfast/openfast_python/openfast_io/turbsim_file.py #2577
Conversation
Thank you for the PR @Gjacquenot, Could you share your specific use case for passing the turbsim BTS file as an argument to the routine? Typically, users would want to load in the |
I have tested it with the wind bts file from r-test repository Then the command is the following, it sums up the content of the two Python pandas dictionaries cd openfast_python
python3 -m openfast_io.turbsim_file wind.bts |
@Gjacquenot, thanks for your reply. I think we are missing some context here. Could you explain why you want to do this as opposed to loading the |
Well, I just wanted to update the default entrypoint that tries to load a non
existing BTS file.
Now, the entrypoint allows to load a bts file and get some infos on it.
I agree that the main usage is still to load the main class from another file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now. Will update the summary in main()
to use __repr__
in #2361
Feature or improvement description
Refactor openfast/openfast_python/openfast_io/turbsim_file.py:
Related issue, if one exists
None
Impacted areas of the software
None
Additional supporting information
None
Test results, if applicable
Tested manually on a bts file found in the submodule