Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a scale widget #798

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Add a scale widget #798

merged 2 commits into from
Mar 22, 2018

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Mar 19, 2018

This adds a scale widget and a tutorial to show it off.

@manthey
Copy link
Contributor Author

manthey commented Mar 19, 2018

All but the last commit are from other PRs. When they are merged, this could be rebased to contain just the relevant commit.

matthewma7
matthewma7 approved these changes Mar 22, 2018
View reviewed changes
Copy link

@matthewma7 matthewma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out the tutorial and tried out the scale widget in a real project with some custom look with options and css. Worked beautifully in both cases.
LGTM, approving.

@manthey manthey merged commit 0f29bb6 into master Mar 22, 2018
@manthey manthey deleted the scale-widget branch March 22, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewma7 matthewma7 matthewma7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manthey @matthewma7