Move width and height to the base renderer class definition. #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces code duplication.
aashish24
reviewed
Nov 23, 2018
| m_width = width; | ||
| m_height = height; | ||
| if (!m_width || !m_height) { | ||
| if (!width || !height) { |
There was a problem hiding this comment.
in vglRenderer we use m_this.width() to get width and height, why not we use the same here? instead of getting it from map?
There was a problem hiding this comment.
A few lines later is where the layer's width and height is set from these values (m_this._setWidthHeight(width, height);), so width and height are the values that will be set.
There was a problem hiding this comment.
I see, I was expecting the flow between vgl and d3 renderers would be same and may be they are similar. so sounds like we are getting the width and height from the map and set it to the renderer in both cases?
aashish24
reviewed
Nov 23, 2018
aashish24
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces code duplication. It has been listed as a TODO in the code for a long time.