Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify syft box ip to https domain name #80

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

rasswanth-s
Copy link
Collaborator

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@rasswanth-s rasswanth-s changed the title modify ip to https domain name modify syft box ip to https domain name Oct 10, 2024
@rasswanth-s rasswanth-s force-pushed the rasswanth/shift-to-domain-name branch from 788f9ff to 6b942a8 Compare October 10, 2024 13:31
@@ -119,6 +119,10 @@ def load_or_create_config(args) -> ClientConfig:
if email_token:
client_config.email_token = email_token

# Migrate Old Server URL to HTTPS
if client_config.server_url == "http://20.168.10.234:8080":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so good! ❤️

@madhavajay madhavajay self-requested a review October 11, 2024 00:00
Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks simple but I appreciate the effort to get https urls going and now were in such an amazing place. ❤️

Giddyup 🐴

@madhavajay madhavajay merged commit 9b8732d into main Oct 11, 2024
1 of 7 checks passed
@yashgorana yashgorana deleted the rasswanth/shift-to-domain-name branch October 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants