Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify syft box ip to https domain name #80

Merged
merged 3 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ uv run syftbox/client/client.py
### Run Client

```
syftbox client --config_path=./config.json --sync_folder=~/Desktop/SyftBox --email=your@email.org --port=8082 --server=http://20.168.10.234:8080
syftbox client --config_path=./config.json --sync_folder=~/Desktop/SyftBox --email=your@email.org --port=8082 --server=https://syftbox.openmined.org
```

### Deploy

This builds the latest source to a wheel and deploys and restarts the server:
http://20.168.10.234:8080
https://syftbox.openmined.org

```
./scripts/deploy.sh
Expand Down
2 changes: 1 addition & 1 deletion scripts/live_andrew.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
uv run syftbox/client/client.py --config_path=./users/live_andrew.json --sync_folder=./users/live_andrew --email=andrew@openmined.org --port=8082 --server=http://20.168.10.234:8080
uv run syftbox/client/client.py --config_path=./users/live_andrew.json --sync_folder=./users/live_andrew --email=andrew@openmined.org --port=8082 --server=https://syftbox.openmined.org
2 changes: 1 addition & 1 deletion scripts/live_madhava.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
uv run syftbox/client/client.py --config_path=./users/live_madhava.json --sync_folder=./users/live_madhava --email=madhava@openmined.org --port=8081 --server=http://20.168.10.234:8080
uv run syftbox/client/client.py --config_path=./users/live_madhava.json --sync_folder=./users/live_madhava --email=madhava@openmined.org --port=8081 --server=https://syftbox.openmined.org
6 changes: 5 additions & 1 deletion syftbox/client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ def load_or_create_config(args) -> ClientConfig:
if email_token:
client_config.email_token = email_token

# Migrate Old Server URL to HTTPS
if client_config.server_url == "http://20.168.10.234:8080":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

client_config.server_url = "https://syftbox.openmined.org"

client_config.save(args.config_path)
return client_config

Expand Down Expand Up @@ -280,7 +284,7 @@ def parse_args():
parser.add_argument(
"--server",
type=str,
default="http://20.168.10.234:8080",
default="https://syftbox.openmined.org",
help="Server",
)
return parser.parse_args()
Expand Down
Loading