Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fr-FR: Apply #2111, #2133, #2140, #2144, #2149, #2158, #2165, #2176, #2181 and improve existing strings #2186

Merged
merged 2 commits into from
Jun 15, 2021
Merged

fr-FR: Apply #2111, #2133, #2140, #2144, #2149, #2158, #2165, #2176, #2181 and improve existing strings #2186

merged 2 commits into from
Jun 15, 2021

Conversation

rmnvgr
Copy link
Contributor

@rmnvgr rmnvgr commented Jun 15, 2021 •
edited
Loading

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
fr-FR 2 (-43) 0 159 (+7)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 324 0 2171
ca-ES 74 0 122
cs-CZ 344 0 266
da-DK 13 0 566
de-DE 0 0 329
en-US 3332 0 390
eo-OO 0 0 82
es-ES 64 0 290
fi-FI 13 0 107
hu-HU 233 0 117
it-IT 36 0 317
ja-JP 97 7 640
ko-KR 0 0 202
nb-NO 318 0 2114
nl-NL 0 12 446
pl-PL 17 0 460
pt-BR 0 0 131
ru-RU 1392 0 143
sv-SE 41 0 358
tr-TR 180 7 425
vi-VN 18 2 3435
zh-CN 170 0 451
zh-TW 115 0 312

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
fr-FR 0 (-45) 0 159 (+7)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 324 0 2171
ca-ES 74 0 122
cs-CZ 344 0 266
da-DK 13 0 566
de-DE 0 0 329
en-US 3332 0 390
eo-OO 0 0 82
es-ES 64 0 290
fi-FI 13 0 107
hu-HU 233 0 117
it-IT 36 0 317
ja-JP 97 7 640
ko-KR 0 0 202
nb-NO 318 0 2114
nl-NL 0 12 446
pl-PL 17 0 460
pt-BR 0 0 131
ru-RU 1392 0 143
sv-SE 41 0 358
tr-TR 180 7 425
vi-VN 18 2 3435
zh-CN 170 0 451
zh-TW 115 0 312

@rmnvgr rmnvgr changed the title fr-FR: Apply #2133, #2140, #2144, #2149, #2158, #2165, #2176, #2181 and improve existing strings fr-FR: Apply #2111, #2133, #2140, #2144, #2149, #2158, #2165, #2176, #2181 and improve existing strings Jun 15, 2021
Gymnasiast
Gymnasiast reviewed Jun 15, 2021
View reviewed changes
data/language/fr-FR.txt
STR_6396 :Désactiver écr. de veille et éco. d’énergie du moniteur
STR_6397 :Si coché, l’écran de veille et d’autres fonctionnalités d’économie d’énergie du moniteur seront désactivés pendant qu’OpenRCT2 est lancé.
STR_6398 :Le fichier contient des types d’attractions non supportés. Veuillez mettre à jour OpenRCT2 vers une version plus récente.
STR_6399 :OpenRCT2 a besoin des fichiers originaux de RollerCoaster Tycoon 2 pour fonctionner. Veuillez indiquer le chemin où vous avez installé RollerCoaster Tycoon 2 dans la variable “game_path” dans le fichier config.ini, puis redémarrez OpenRCT2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought French used guillemets. Or is that only for quotations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guillemets are for quotations, for variables, italics are preferred, but this is impossible here. I used the same quotation marks that are used elsewhere in the translation, but I can replace all of them with guillemets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if guillemets are only for quotations, then I’m not going to ask you to use them here. After all, I want the translation to be correct for French.

We don’t support italics, indeed. Instead, you could use {SMALLFONT}game_path{MEDIUMFONT}. It will print the text in another font. But I will leave it up you to decide if that is an improvement or if sticking with “” is best after all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may use {SMALLFONT} indeed. The original RCT2 translation uses double quotations instead of guillemets, so I'll change them too.

@Gymnasiast Gymnasiast merged commit 807a9c1 into OpenRCT2:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmnvgr @Gymnasiast