Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong line numbers in amendment after adding change recommendation #2820

Closed
jsangmeister opened this issue Sep 18, 2023 · 2 comments
Closed
Labels
Milestone

Comments

@jsangmeister
Copy link
Contributor

jsangmeister commented Sep 18, 2023

How to reproduce:

  1. create motion with multiple lines
  2. create amendment which changes some of the later lines (the amendment detail view must not start with line number 1)
  3. create change recommendation to any line in the amendment
  4. delete change recommendation -> the line number in the amendment reset and start at 1

If you try to create a new change recommendation afterwards, the displayed line numbers are used and the lines from the original motion are used, which is especially confusing.

@jsangmeister jsangmeister added this to the 4.1 milestone Sep 18, 2023
@rrenkert rrenkert added the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Oct 16, 2023
@Elblinator
Copy link
Member

Step by step guide:

  1. created a new motion with several (in my case 7) lines and paragraphs (every line is a paragraph
  2. created an amendment which changed 4 lines (first, third, fourth, fifth)
  3. created a change request for Line 4
  4. reloaded page (see Missing autoupdate for first change recommendation in amendment #2945 for reasons for reload)
  5. line numbers are wrong:
    010 A

after deleting the change recommendation and reloading the page the correct lines are displayed again

@Elblinator Elblinator changed the title Wrong line numbers in amendment after deleting change recommendation Wrong line numbers in amendment after adding change recommendation Oct 25, 2023
@Elblinator Elblinator removed the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Oct 25, 2023
@Elblinator
Copy link
Member

the issue is moved to a meta-issue #2946
This issue will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants