Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment-detail fix change recommendation #2946

Closed
9 of 10 tasks
Tracked by #2956
Elblinator opened this issue Oct 25, 2023 · 8 comments · Fixed by #4024
Closed
9 of 10 tasks
Tracked by #2956

Amendment-detail fix change recommendation #2946

Elblinator opened this issue Oct 25, 2023 · 8 comments · Fixed by #4024
Assignees
Labels
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented Oct 25, 2023

Current behaviour:
In Amendment-detail view (you need an amendment which changes more than one line)

  • A. If a change recommendation is added then the original version of the motion is displayed, not the Diff Version anymore.
  • B. If the change recommendation is deleted then you need to reload the page to see the change recommendation anymore
  • B.1. If a change recommendation is added, the whole motion text can't be activated with the checkbox "Show entire motion text". By clicking it an error appears in the console. Error message "Cannot read properties of null (reading 'offsetTop')"
  • C. If an amendment changes several lines and has one change request then the line numbers are not correctly displayed
  • D. If an amendment has a change recommendation then the option "show entire motion text" vanishes

Descriptions changed because Case C and D are resolved and A/B needed a rework.

Reproduction:
In a meeting:

  1. create a motion with several lines/paragraphs (I recommend 7 lines)
  2. create an amendment which changes several (but not all) lines in the motion
  3. add a change recommendation to the amendment
    3.1. hover around the beginning of the sentence (a bit more to the left) until you find a blue cross-icon
    3.2. press the icon
    3.3. change something in the sentence and save (hint: doesn't matter, if it is a part of the change recommendation or the regular text.)
  4. ( Case A) ) now the original version of the amendment is active, not the Diff Version (compare: in a motion the Diff Version is active after adding a change recommendation.)
  5. (Case B) Original version must be active.- Open the console. Now activate the checkbox "Show entire motion text". An Error message appears in the console. The entire motion is not displayed. -> Reload the page to switch back to a working version.
  6. (Case B.1) Delete the change recommendation. -> CR stays active and visible. By deleting it twice, a correct error message appears.
  7. reload the page -> the change recommedantion is gone

Wanted behaviour:

  • A. - After adding a change recommendation to an amendment, the Diff Version should be visible. It should follow the same logic like adding an amendment to a motion. Please check, if this is connected to the function "Default text version for change recommendations and projections of motions".
  • B. - the change recommendation should vanish after deletion without reload
  • B.1 - activated checkbox "Show entire motion text" should show whole motion text
  • the displayed lines should be correct even if there is a change request
  • the optiojjn to display the whole text should always be available
@Elblinator
Copy link
Member Author

Case D) only happens if the Diff Version is selected. @emanuelschuetze @MSoeb is this a feature?

If it is, ignore D)

@Elblinator
Copy link
Member Author

Elblinator commented Nov 6, 2023

Case C is solved by #2970

@Elblinator
Copy link
Member Author

Case D) is wanted behaviour

@Elblinator Elblinator changed the title [Meta] Amendment-detail fix change recommendation Amendment-detail fix change recommendation Nov 10, 2023
@Elblinator Elblinator modified the milestones: 4.1, 4.2 Dec 6, 2023
@MSoeb
Copy link

MSoeb commented Dec 18, 2023

Re-Tested and rewrited the issue:

  • Case A: Edit to reflect the occuring problem
  • Case B: Still occurs. Also found another problem which is strongly connected to it. Integrated it in the issue in B.1

@reiterl
Copy link
Member

reiterl commented Feb 7, 2024

I looked into Case A: I can reproduce a failure there. In the os-motion-highlight-form the function determineCrMode
doesn't work in this case. It sets the cr mode to original in a if clause, which shouldn't happen. The hasChangeRecommendation property returns a false, but it should return a true. I need more time to debug this.

@reiterl
Copy link
Member

reiterl commented Feb 8, 2024

Add some fixes. I debugged here a lot, but there are still some issues here. I stop working on this.
Case A and part of B1 should be fixed.

@reiterl reiterl removed their assignment Feb 8, 2024
@MSoeb
Copy link

MSoeb commented Aug 16, 2024

Re-Test:
Case A) still occurs
Case B) CR deletion -> still occurs
Case B.1) can't reproduce it. seems to work correctly

@bastianjoel bastianjoel self-assigned this Aug 16, 2024
@bastianjoel
Copy link
Member

Very likely to be resolved after #4023 is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants