-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion detail refactoring #4024
Motion detail refactoring #4024
Conversation
e1fbe78
to
4754a16
Compare
4754a16
to
3724a94
Compare
Change detection for amendments and crs not working yet
385b402
to
1795554
Compare
45dceaf
to
1424705
Compare
1424705
to
4eca6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If a motion was never forwarded (but can be forwarded then the forward button should be visible. Currently the button is initially not there, and if you press in the meta-data then the button appears
- Edit whole motion text amendment parent not loaded #4041 following the reproduction is giving the following result:
motion before reload:
after reload:
- The meta-data Category, Tags and Motion block should be hidden if there is no category/tag/motion block
- If a motion title has a change recommendation then the indicator is always shown. The title should only have the indicator if the original version is shown.
2nd and 3rd are moved to the commend below
4th is a non-issue after the explanation
Title indicator is displayed on diff and original version which I think is okay, as the title change does not get displayed directly but instead in the motion content. Also that behavior is the same as before the indicator was broken. Empty category, tags and block areas do get hidden for users which cannot edit those areas. Cannot replicate. Amendment form also works for me. |
Failed to connect an existing shared worker because the type or credentials given on the SharedWorker constructor doesn't match the existing shared worker's type or credentials.
|
Still cannot reproduce #4041. Tried this now in Firefox, Chromium with and without shared worker active. Everything worked. |
I cannot reproduce this and also I don't think this in related to this PR. |
This in happening on current main too. Please open a new issue. I won't fix this here. |
Will be fixed with #4066. Same issue happens when deleting other models. |
payload:
|
Cannot reproduce
Also works for me |
If a motion block/tag/catgory is deleted and no item is left then the motion detail needs a reload in order to hide the options |
Yes |
resolves #4023
resolves #3605
resolves #4041
resolves #2719
resolves #1664 - prevent unnecessary model store updates from data by merged subscriptions
resolves #4052
resolves #2946
Other changes
viewModelUpdateTimestamp
following additional issues will be addressed here too:
Improve the motion detail view #1002TODO (not a full list of changes):
Useos-motion-comment
inos-motion-personal-note
MotionManageTitleComponent
MotionManagePollsComponent
MotionManageMotionMeetingUsersComponent
MotionHighlightFormComponent
MotionExtensionFieldComponent
MotionDetailDiffSummaryComponent
MotionAddPollComponent
BaseMotionDetailChildComponent
editMode
logicMotionServiceCollector
MotionDetailViewService
accessorsAmendmentCreateWizard
intoMotionFormModule
AmendmentCreateWizard
by using the motion base form@else
/@else if
@for
track
parametersMotionDetailViewService