Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masking for feature detection #104

Closed
wants to merge 1 commit into from
Closed

Add masking for feature detection #104

wants to merge 1 commit into from

Conversation

3nol
Copy link
Contributor

@3nol 3nol commented Jun 30, 2023

I created this PR as a follow-up for PR#55 since no further progress has been made. I based my implementation on @piercus's attempt, so he receives partial credit.

I only implemented the first part of the above PR (feature masking, not background stitching etc.). But I think this is already very helpful for stitching.

This PR adds:

  • The --masks cli parameter (as mentioned, only feature masks for now)
  • Change to the ImageHandler to allow storing mask file names, as well as corresponding accessors
  • An additional test for feature masking in test_detector.py

@3nol 3nol mentioned this pull request Jun 30, 2023
@piercus
Copy link

piercus commented Jun 30, 2023

Looks great ! Thanks for the follow-up !

I feel focusing on features only is the best choice !

@lukasalexanderweber
Copy link
Member

Thanks for keeping up on this! I'm leaving into holiday and need some time to review this, I hope its fine that I check back to you when I'm back.

@lukasalexanderweber
Copy link
Member

lukasalexanderweber commented Jul 21, 2023

During the review of the PR I noticed that the ImageHander has too much state and also a bug (817c3d0). I would like to refactor/fix this first, because I think that then not so much code has to be inserted into the image handler, which is already too complicated for my taste. I hope this is fine for you.

@lukasalexanderweber
Copy link
Member

what would be helpful in the meantime is a test where the full stitching worklow is run with and without feature masks and we see that different results are achieved. You could place the images here, we could then present the feature in the tutorial and download it from there for out tests.

@3nol
Copy link
Contributor Author

3nol commented Jul 21, 2023

Thanks for looking into this again! Yes, that sounds like a good idea. After all, using masks is a very user-facing feature, and a tutorial with working examples might be very helpful.

I will add a test with the full stitching workflow (and example images) in the next couple days.

Edit: I am sorry, I won't be able to finish this soon. If anyone wants to help, please feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants