Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow up to #55 and #104
Co-authored-by: Pierre Colle piercus@gmail.com
Co-authored-by: Leon Wenzler leon.wenzler@uni.kn
@piercus @3nol thanks for your precious input
here the test:
the images are stitched at the barcode since it has many features:
![01_feat ![barcode1](https://github.co barcode2 m/OpenStitching/stitching/assets/32765578/5e3d3000-fff8-41e6-9f00-f1835d0b071c) ures_img1](https://private-user-images.githubusercontent.com/32765578/261458550-312c0685-eb34-4629-86ea-0f9e5c6254aa.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg1NTAtMzEyYzA2ODUtZWIzNC00NjI5LTg2ZWEtMGY5ZTVjNjI1NGFhLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiZWZlZjY1NjNhNDkwNDAzYjI4NDAyYzVkNjEwMzg2MjRmYWMzZmU5MDJlZWIzOGIyODRkNGY2NDlhNTdmNTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.nWm0iayfgW8pBOB2xHEUBKWM_Z4bbhlA-VI1LyvG9NA)
![01_features_img2](https://private-user-images.githubusercontent.com/32765578/261458557-4016f02c-a1b8-46d8-a2a1-cb402183707a.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg1NTctNDAxNmYwMmMtYTFiOC00NmQ4LWEyYTEtY2I0MDIxODM3MDdhLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFjYzIxYzA2ZTlmYjNhOGEyYWNkNjdhYzI1YWQ2Y2YzZGU2MzljYjFhYjFjYmQ5OTIzNDQ5ODBhNDFkMmU0OGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Z0oGUOOZC8xtueeFaGZt9qgarYc0_sefbyK6wa4BQJI)
![02_matches_img1_to_img2](https://private-user-images.githubusercontent.com/32765578/261458566-08ec061d-1b63-4eab-949c-a9db089f48b6.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg1NjYtMDhlYzA2MWQtMWI2My00ZWFiLTk0OWMtYTlkYjA4OWY0OGI2LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkNmQzMjEyMjdmMjJjMDM3ZTZmYWY1ZjQzMDczY2EyYzhlZGY1ZWU4YTQwNjFkOWI4YWQwOTA0NTdkNGYzODImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VR7q4eVCzzMCYtmYPMihiMMJF49Tuto9LbqDB1srft4)
![09_result](https://private-user-images.githubusercontent.com/32765578/261458582-3bba4c93-f9f8-4be1-8d71-44a60edd5742.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg1ODItM2JiYTRjOTMtZjlmOC00YmUxLThkNzEtNDRhNjBlZGQ1NzQyLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyZTFhODBlNjc1MzJlZmJkYjA4YTQxMjNlOTFjZWJhNjhlNGYzYWU4MWFkOWViN2NiNmNkNzE2MDc0N2ExZWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vKL1TpYeNW7OFCs-z2ZjfTFQox4Nks0AsUq5xw0jmek)
We can now add feature masks so features are NOT searched at the barcode:
![mask1](https://private-user-images.githubusercontent.com/32765578/261458666-39dca355-907c-4751-a6c7-5b22c3aae41e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg2NjYtMzlkY2EzNTUtOTA3Yy00NzUxLWE2YzctNWIyMmMzYWFlNDFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwMWIwYTFkMzNlZGU2MWQ3ZTExMGQxOTdmNTBkNTFhNGQzNTliZmNkMzhmNjJlMzBlYjFkNDQ1NmU5NDUxYzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._QF52Fx8R5ukCp9Ofl_yycIIEtuPpVrW2ChwMRVZH5Q)
![mask2](https://private-user-images.githubusercontent.com/32765578/261458674-be024f12-69e5-4d29-9cfd-57c3a056f046.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg2NzQtYmUwMjRmMTItNjllNS00ZDI5LTljZmQtNTdjM2EwNTZmMDQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4NjVlNjU1ZDMzNzljMzdhZTY0MTIwZmRkYzZkN2JmNWY4ZDY5NWRmY2U5NzZmZDI2MThiNTdmMWQxZTlkNDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.A0gzLlBZQwKXXBD-Q6D98bp39gT1xzMAxAIY-a_xjlc)
![01_features_img1](https://private-user-images.githubusercontent.com/32765578/261458702-e97f80d4-2e43-4bf6-8353-2d1c2c1a772d.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg3MDItZTk3ZjgwZDQtMmU0My00YmY2LTgzNTMtMmQxYzJjMWE3NzJkLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwM2NiNGM2MWIzYThjMThhNzgwYTZiOGVjNjkyNDFlNWQ2NTZkZWYyMDQ1OTVkNmEzZjY4ZDhlNDc2MjRiNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.K9suwo7l1v0qSfwRm-xL0uVuHMp31_KBE29kugnw1qQ)
![01_features_img2](https://private-user-images.githubusercontent.com/32765578/261458707-ff97cefc-c8b7-46ff-883b-2e693825d021.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg3MDctZmY5N2NlZmMtYzhiNy00NmZmLTg4M2ItMmU2OTM4MjVkMDIxLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzM2E4ZDQ4ZGMzNzJjM2UwOGNmMjk4NTQyMDE2OWNlY2JiZTdkNDBhY2Y3YWE2NjY0MDU5YTNkNzEzZDMxNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fKV32UM40wOtIbnwoi79QY9hJarYgsaP0vyDreyv1kI)
![02_matches_img1_to_img2](https://private-user-images.githubusercontent.com/32765578/261458715-f1681e00-646c-4f2c-9c38-fedc4a26ba74.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg3MTUtZjE2ODFlMDAtNjQ2Yy00ZjJjLTljMzgtZmVkYzRhMjZiYTc0LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAzOTRjNDgxMzBhMjg3YTQzY2Q2MTU4MWE2NDkyZTE2ODNkN2IyMmRkYjM0OGY3NGUyNWIzNTYwZjAxM2RmZmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7Hyn9EQ781xyGz9UxPJ2ZPlxG-R_sAU7H9e5S9ZA5io)
![09_result](https://private-user-images.githubusercontent.com/32765578/261458729-446de7c8-0d71-483b-9a77-55ff55411ed4.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMzQzODEsIm5iZiI6MTczOTIzNDA4MSwicGF0aCI6Ii8zMjc2NTU3OC8yNjE0NTg3MjktNDQ2ZGU3YzgtMGQ3MS00ODNiLTlhNzctNTVmZjU1NDExZWQ0LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAwMzQ0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4YTQyNTVjMTRmYTMyNzM2ZTY5NzI1NmNmNjcwOTZjNWM4Y2QzYWMyNzRiYTJhNzhhNzI5ODIxZWQ5YzAxNTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.u846J9VLRitEIe7nAqARko5Ip3vb4H_Oeyr9vtBKqfE)