Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dep updates #1607

Merged
merged 1 commit into from
May 22, 2019
Merged

Some dep updates #1607

merged 1 commit into from
May 22, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented May 22, 2019

  • Please read their CHANGELOGs ... and there is a lot
  • Delete op retested

NOTES:

  • async@3.x may not support IE11 well... needs further testing... failure on dev script source in Chromium 73.0.3683.86 and quite sluggish on dev
  • Further kerberos failures... no updates yet:
~/.node-gyp/12.3.0/include/node/node.h:107:12: fatal error: util-inl.h: No such file or directory

... ignoring for now since it's still a very highly optional dep:

Refs:

* Please read their CHANGELOGs ... and there is a lot
* Delete op retested

NOTES:
* *async*@3.x may not support IE11 well... needs further testing... failure on dev script source in Chromium 73.0.3683.86 and quite sluggish on dev
* Further *kerberos* failures... no updates yet:

``` console
~/.node-gyp/12.3.0/include/node/node.h:107:12: fatal error: util-inl.h: No such file or directory
```

... ignoring for now since it's still a very highly optional dep:

* https://stackoverflow.com/questions/40432272/cannot-open-include-file-src-gtest-internal-inl-h-no-such-file-or-directory (some solution but seems to be *node* related)
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels May 22, 2019
@Martii Martii merged commit 3125806 into OpenUserJS:master May 22, 2019
@Martii Martii deleted the someDepUpdates branch May 22, 2019 08:27
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Aug 21, 2019
* *async*@3.x migration
* Using a more applicable statusCodePage for DB S3 connection issue... the error message is still rather vague since it's abstracted several times between function calls but was tested and landed on 404 during *fakeS3* usage. At some point when all callback signatures can be set to `aErr`, `aResults` this should be more explicit... until then preserving existing vagueness.
* Revert OpenUserJS#1599 as Fx still uses this in 68.x. TLSv1 EOL will still prevent Opera Presto from even visiting the site.

NOTES:
* Apparently version 3.x migration is extremely picky now about how Err is generated. i.e. it doesn't allow `true`/`false` anymore like it did in version 2.x. This causes the request to never complete with `async.parallel`. The web spinner and no source is retrieved even though **it was successfully retrieved**.
* Been probing/testing dev manually and it seems to be non-sluggish atm with Fx 68.x... perhaps a change from 3.0 to 3.1 of this dep... or even Chromium report since distro version is/was a bit buggy at the time of testing.

Post OpenUserJS#1607 OpenUserJS#1520
Martii added a commit that referenced this pull request Aug 21, 2019
* *async*@3.x migration
* Using a more applicable statusCodePage for DB S3 connection issue... the error message is still rather vague since it's abstracted several times between function calls but was tested and landed on 404 during *fakeS3* usage. At some point when all callback signatures can be set to `aErr`, `aResults` this should be more explicit... until then preserving existing vagueness.
* Revert #1599 as Fx still uses this in 68.x. TLSv1 EOL will still prevent Opera Presto from even visiting the site.

NOTES:
* Apparently version 3.x migration is extremely picky now about how Err is generated. i.e. it doesn't allow `true`/`false` anymore like it did in version 2.x. This causes the request to never complete with `async.parallel`. The web spinner and no source is retrieved even though **it was successfully retrieved**.
* Been probing/testing dev manually and it seems to be non-sluggish atm with Fx 68.x... perhaps a change from 3.0 to 3.1 of this dep... or even Chromium report since distro version is/was a bit buggy at the time of testing.

Post #1607 #1520

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant