A dep change #1520
Merged
A dep change #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove *fakes3* dep and all associated Ruby/Rails for pure JavaScript implementation * New dev dep *S3rver* handles what we need with basic i/o for S3 on dev. Please read their homepage * Leaving *fakeS3* `.gitignore`'s in for current data path... please delete your copies as this should eventually go away... or you can manually migrate it yourself perhaps. I'll just reimport from GH the sources on dev which is a better use of my time. * Fix a potential `undefined` I put in trap a while back with a generic string. * Change all docs to accommodate this * Moved a native dependency up top (the TODO)... code style conformance * DELETE OP RETESTED... PASS NOTE: * Contributors, and up, should no longer need to launch the server as it's launched in dev automatically and should terminate with a SIGINT (app exit). Remote local hosts still supported although I've never used that myself. Closes OpenUserJS#1519
Martii
added
bug
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Sep 23, 2018
NOTE: Interesting... proc manager didn't show any error... e.g. `npm install` didn't install the dependency. Top level code compliance needed. Post OpenUserJS#1520
Merged
Martii
added a commit
that referenced
this pull request
Sep 23, 2018
NOTE: Interesting... proc manager didn't show any error... e.g. `npm install` didn't install the dependency. Top level code compliance needed. Post #1520 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Sep 24, 2018
Merged
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Mar 19, 2019
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 12, 2019
* Force update *s3rver* migration * This is a breaking change for dev. Project version bump. All dev sources previously there must be reimported/rewritten/reuploaded *(again, from when we left *fakes3* in OpenUserJS#1520 )*. e.g. this is not forward or backward compatible. * Bucket configuration and CORS config doesn't appear to be needed on *s3rver* NOTES: * Untested on pro but should probably work since it's been working this way. Dev Source Code tab pulls and no bucket errs. Will test momentarily on pro to ensure it is 100%. * Documentation is still dispersed for this dependency and partially pulled from example folder * Seems to be more inline with pro options for *aws-sdk*
Merged
Martii
added a commit
that referenced
this pull request
Jun 12, 2019
* Force update *s3rver* migration * This is a breaking change for dev. Project version bump. All dev sources previously there must be reimported/rewritten/reuploaded *(again, from when we left *fakes3* in #1520 )*. e.g. this is not forward or backward compatible. * Bucket configuration and CORS config doesn't appear to be needed on *s3rver* NOTES: * Untested on pro but should probably work since it's been working this way. Dev Source Code tab pulls and no bucket errs. Will test momentarily on pro to ensure it is 100%. * Documentation is still dispersed for this dependency and partially pulled from example folder * Seems to be more inline with pro options for *aws-sdk* Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 21, 2019
* *async*@3.x migration * Using a more applicable statusCodePage for DB S3 connection issue... the error message is still rather vague since it's abstracted several times between function calls but was tested and landed on 404 during *fakeS3* usage. At some point when all callback signatures can be set to `aErr`, `aResults` this should be more explicit... until then preserving existing vagueness. * Revert OpenUserJS#1599 as Fx still uses this in 68.x. TLSv1 EOL will still prevent Opera Presto from even visiting the site. NOTES: * Apparently version 3.x migration is extremely picky now about how Err is generated. i.e. it doesn't allow `true`/`false` anymore like it did in version 2.x. This causes the request to never complete with `async.parallel`. The web spinner and no source is retrieved even though **it was successfully retrieved**. * Been probing/testing dev manually and it seems to be non-sluggish atm with Fx 68.x... perhaps a change from 3.0 to 3.1 of this dep... or even Chromium report since distro version is/was a bit buggy at the time of testing. Post OpenUserJS#1607 OpenUserJS#1520
Martii
added a commit
that referenced
this pull request
Aug 21, 2019
* *async*@3.x migration * Using a more applicable statusCodePage for DB S3 connection issue... the error message is still rather vague since it's abstracted several times between function calls but was tested and landed on 404 during *fakeS3* usage. At some point when all callback signatures can be set to `aErr`, `aResults` this should be more explicit... until then preserving existing vagueness. * Revert #1599 as Fx still uses this in 68.x. TLSv1 EOL will still prevent Opera Presto from even visiting the site. NOTES: * Apparently version 3.x migration is extremely picky now about how Err is generated. i.e. it doesn't allow `true`/`false` anymore like it did in version 2.x. This causes the request to never complete with `async.parallel`. The web spinner and no source is retrieved even though **it was successfully retrieved**. * Been probing/testing dev manually and it seems to be non-sluggish atm with Fx 68.x... perhaps a change from 3.0 to 3.1 of this dep... or even Chromium report since distro version is/was a bit buggy at the time of testing. Post #1607 #1520 Auto-merge
Martii
added a commit
that referenced
this pull request
Aug 27, 2019
* Remove fakes3 instructions * Amend BLOCKING to allow for documentation fixes... as long as it's not code related I don't see an issue with fixing typos or adding new .user.js engines since it's more or less like a wiki. Post #1520
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore's in for current data path... please delete your copies as this should eventually go away... or you can manually migrate it yourself perhaps. I'll just reimport from GH the sources on dev which is a better use of my time.undefinedI put in trap a while back with a generic string.NOTE:
Closes #1519