Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A dep update/change #1620

Merged
merged 1 commit into from
Jun 12, 2019
Merged

A dep update/change #1620

merged 1 commit into from
Jun 12, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 12, 2019

  • Force update s3rver migration
  • This is a breaking change for dev. Project version bump. All dev sources previously there must be reimported/rewritten/reuploaded (again, from when we left fakes3 in A dep change #1520 ). e.g. this is not forward or backward compatible.
  • Bucket configuration and CORS config doesn't appear to be needed on s3rver

NOTES:

  • Untested on pro but should probably work since it's been working this way. Dev Source Code tab pulls and no bucket errs. Will test momentarily on pro to ensure it is 100%.
  • Documentation is still dispersed for this dependency and partially pulled from example folder
  • Seems to be more inline with pro options for aws-sdk

@Martii
A dep update/change
b467f54 
* Force update *s3rver* migration
* This is a breaking change for dev. Project version bump. All dev sources previously there must be reimported/rewritten/reuploaded *(again, from when we left *fakes3* in OpenUserJS#1520 )*. e.g. this is not forward or backward compatible.
* Bucket configuration and CORS config doesn't appear to be needed on *s3rver*

NOTES:
* Untested on pro but should probably work since it's been working this way. Dev Source Code tab pulls and no bucket errs. Will test momentarily on pro to ensure it is 100%.
* Documentation is still dispersed for this dependency and partially pulled from example folder
* Seems to be more inline with pro options for *aws-sdk*
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 12, 2019
@Martii Martii merged commit 52ba40d into OpenUserJS:master Jun 12, 2019
@Martii Martii deleted the aDepUpdateChange branch June 12, 2019 21:59
@Martii Martii added the needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. label Jun 12, 2019
@Martii
Copy link
Member Author

Martii commented Jun 12, 2019 •
edited
Loading

Existing source still available... PASS
Sync and storage test... PASS

@Martii Martii removed the needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. label Jul 11, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii