-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
difftest: writeback support for dual core #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a mix of camelCase (e.g., numPhyRegs
, wb_int
) and snake_case (e.g., wb_for_skip
) naming conventions. To improve consistency and readability, I recommend unifying the naming style throughout the code. In Scala, the generally preferred style for variables and methods is camelCase.
Suggestions:
- Rename
wb_for_skip
towbForSkip
. - ....
This minor change will help maintain a cohesive code style and make the code easier to understand for future contributors.
I agree with you on the importance of consistent code styles. We prefer to use automated code style checker to ensure the format is consistent. If you have some ideas on this, GitHub Issues/PRs are welcome and much appreciated |
I have created a PR about this issue.😊 |
Record the writeback according to `coreid`.
Multicore support for hasdut added on Paladin or VCS