Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SignatureBouncer test for when msg.data is too short #1360

Merged
merged 3 commits into from
Sep 27, 2018
Merged

Add SignatureBouncer test for when msg.data is too short #1360

merged 3 commits into from
Sep 27, 2018

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Sep 27, 2018

This should bring coverage from 99.873% to 100%. If not then the PR needs more work.

@frangio frangio added kind:improvement tests Test suite and helpers. labels Sep 27, 2018
@frangio frangio added this to the v2.0 milestone Sep 27, 2018
@frangio
Copy link
Contributor Author

frangio commented Sep 27, 2018

Coverage remained the same.

Trying a new approach now.

nventuro
nventuro approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @frangio, thanks!

@nventuro nventuro merged commit 1a4e534 into OpenZeppelin:master Sep 27, 2018
@frangio frangio deleted the signature-tests2 branch September 28, 2018 01:35
nventuro pushed a commit that referenced this pull request Sep 28, 2018
@frangio @nventuro
Add SignatureBouncer test for when msg.data is too short (#1360)
8c394de 
* add test for msg.data too short

* fix test to hit that branch

* Update SignatureBouncer.test.js

(cherry picked from commit 1a4e534)
frangio added a commit to frangio/openzeppelin-contracts that referenced this pull request Sep 28, 2018
@frangio
Add SignatureBouncer test for when msg.data is too short (OpenZeppeli…
ec1ddc8 
…n#1360)

* add test for msg.data too short

* fix test to hit that branch

* Update SignatureBouncer.test.js

(cherry picked from commit 1a4e534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@frangio @nventuro