Add SignatureBouncer test for when msg.data is too short (OpenZeppeli…

…n#1360) * add test for msg.data too short * fix test to hit that branch * Update SignatureBouncer.test.js (cherry picked from commit 1a4e534)
frangio · Sep 28, 2018 · ec1ddc8 · ec1ddc8
1 parent fa5ecd0
commit ec1ddc8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/contracts/mocks/SignatureBouncerMock.sol b/contracts/mocks/SignatureBouncerMock.sol
@@ -64,4 +64,11 @@ contract SignatureBouncerMock is SignatureBouncer, SignerRoleMock {
   {
 
   }
+
+  function tooShortMsgData()
+    public
+    onlyValidSignatureAndData("")
+    view
+  {
+  }
 }
diff --git a/test/drafts/SignatureBouncer.test.js b/test/drafts/SignatureBouncer.test.js
@@ -128,6 +128,12 @@ contract('SignatureBouncer', function ([_, signer, otherSigner, anyone, authoriz
           )
         );
       });
+
+      it('does not allow msg.data shorter than SIGNATURE_SIZE', async function () {
+        await assertRevert(
+          this.sigBouncer.tooShortMsgData({ from: authorizedUser })
+        );
+      });
     });
   });