Unsigned conversion #2111 #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update SafeCastMock - Add tests for SafeCast int256 to uint256
nventuro
reviewed
Mar 16, 2020
There was a problem hiding this comment.
Thanks a lot for your contribution @pepelu! I left some minor comments on the code.
About the tests, I noticed you copied the approach from the tests for the other functions. I think we could go with something much simpler: have a single describe block for toUint256 and then test some simple cases, like:
- 0
- 1
- -1
- MAX_UINT256
- MIN_INT256
What do you think?
Apply suggestions from code review. Co-Authored-By: Nicolás Venturo <nicolas.venturo@gmail.com>
|
I completely agree with your updates. I'll look now into the tests. |
|
I can also add the inverse (unsigned to signed). I wanted to do just one first to see if everything was ok. |
- Change "downcasts" to "casts" - Move test closer to its function
- Add function - Add mock - Add test
nventuro
reviewed
Mar 19, 2020
nventuro
reviewed
Mar 19, 2020
- Update error in conversion to be more clear - Update constants in test to be powers of 2 instead of shifts
- Add minus in INT256_MIN for clarity Co-Authored-By: Nicolás Venturo <nicolas.venturo@gmail.com>
|
Thanks for your guidance in my first PR @nventuro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2111
Add signed to unsigned conversion to SafeCast and its corresponding tests.