Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsigned conversion #2111 #2123

Merged
merged 14 commits into from
Mar 27, 2020
Merged

Unsigned conversion #2111 #2123

merged 14 commits into from
Mar 27, 2020

Commits on Mar 12, 2020

  1. Add signed to unsigned conversion to SafeCast

    @pepelu
    pepelu committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    7b4d1b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Update SafeCast exception message

    @pepelu
    pepelu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    d5b9bb2 View commit details
    Browse the repository at this point in the history

  2. Add test for SafeCast int to uint conversion 

    - Update SafeCastMock
- Add tests for SafeCast int256 to uint256
    @pepelu
    pepelu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    3de28ef View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. Merge branch 'master' into unsigned-conversion-#2111

    @pepelu
    pepelu committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    1feee9b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Update SafeCast int to uint definition 

    Apply suggestions from code review.

Co-Authored-By: Nicolás Venturo <nicolas.venturo@gmail.com>
    @pepelu @nventuro
    pepelu and nventuro committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    598b97c View commit details
    Browse the repository at this point in the history

  2. Update test for SafeCast int to uint conversion

    @pepelu
    pepelu committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    9cfed7c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Update SafeCast test after code review 

    - Change "downcasts" to "casts"
- Move test closer to its function
    @pepelu
    pepelu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    76f10a7 View commit details
    Browse the repository at this point in the history

  2. Fix error in SafeCast toUint256 description

    @pepelu
    pepelu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4e96abf View commit details
    Browse the repository at this point in the history

  3. Fix breaking error in SafeCast

    @pepelu
    pepelu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    c6b1ec5 View commit details
    Browse the repository at this point in the history

  4. Add uint256 to int256 conversion to SafeCast 

    - Add function
- Add mock
- Add test
    @pepelu
    pepelu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    e7b08d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Merge branch 'master' into unsigned-conversion-#2111

    @nventuro
    nventuro committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9b3fbaa View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Update SafeCast unsigned to signed conversion 

    - Update error in conversion to be more clear
- Update constants in test to be powers of 2 instead of shifts
    @pepelu
    pepelu committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c62294e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Add changelog entry

    @nventuro
    nventuro committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    6ca3842 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Update SafeCast tests 

    - Add minus in INT256_MIN for clarity

Co-Authored-By: Nicolás Venturo <nicolas.venturo@gmail.com>
    @pepelu @nventuro
    pepelu and nventuro committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    71a0bc7 View commit details
    Browse the repository at this point in the history