Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative fix for the TransparentUpgradeableProxy "decoding" bug #4168

Closed

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Apr 6, 2023

Partly revert and replace #4154.

This alternative fix is motivated by the goal to make more localized changes, since #4154 is a larger refactor.

Since the first commit in this PR is a revert of 5523c14 (#4154), it's better to see the diff against its parent.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

⚠️ No Changeset found

Latest commit: fae9f5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frangio frangio requested a review from ernestognw April 6, 2023 19:05
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this alternative with Seppi and his main concern was related to extensibility. I don't think we should expect issues with overriding (agree they shouldn't be frequent and not recommended), but any modification to this contract will face the issue of needing to mine a clashing selector.

I share the same concern for legitimate possible use cases.

@frangio
Copy link
Contributor

frangio commented Apr 6, 2023

any modification to this contract will face the issue of needing to mine a clashing selector.

In my view, this is not something that is introduced by this PR, it's just implied by the transparency requirement.

The alternative is #4154, which makes extending the proxy a little more cumbersome.

@frangio
Copy link
Contributor

frangio commented Apr 6, 2023

I've updated the docs a little, with a focus on how they appear in the site.

@frangio
Copy link
Contributor

frangio commented Apr 12, 2023

We've decided to keep the fix from #4154.

Moved the docs improvements to its own PR: #4181

@frangio frangio closed this Apr 12, 2023
@Amxx Amxx deleted the fix/proxy/TransparentUpgradeableProxy branch April 3, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants