Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for transparent proxy #4181

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Apr 12, 2023

Ports some of the documentation improvements from #4168 and emphasizes that we don't recommend extending the contract.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: 63a90ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw previously approved these changes Apr 12, 2023
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, LGTM as is the same as in #4168

Co-authored-by: Ernesto García <ernestognw@gmail.com>
@frangio frangio merged commit 3b11799 into OpenZeppelin:master Apr 13, 2023
@frangio frangio deleted the transparent-docs branch April 13, 2023 14:04
frangio added a commit that referenced this pull request Apr 13, 2023
Co-authored-by: Ernesto García <ernestognw@gmail.com>
(cherry picked from commit 3b11799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants